From 50af15e6b8e5ca69052e34d1fbe1aed3831f1d89 Mon Sep 17 00:00:00 2001 From: Emil Militzer Date: Mon, 24 Apr 2023 10:39:08 +0200 Subject: [PATCH] LibWeb: Fix the update of the favicon during navigation The check on the currently active document for an existing favicon has been removed. It caused an issue during navigation because the active document will only be updated after the load and the favicon check has been executed against the old document. --- Userland/Libraries/LibWeb/Loader/FrameLoader.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp b/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp index e1e8cd3a39..23ecd39cd8 100644 --- a/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp +++ b/Userland/Libraries/LibWeb/Loader/FrameLoader.cpp @@ -267,10 +267,6 @@ bool FrameLoader::load(LoadRequest& request, Type type) if (type == Type::IFrame) return true; - auto* document = browsing_context().active_document(); - if (document && document->has_active_favicon()) - return true; - if (url.scheme() == "http" || url.scheme() == "https") { AK::URL favicon_url; favicon_url.set_scheme(url.scheme());