RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:47:44 +00:00
Code Issues Activity Actions

LibAudio: Add a test for creating and destructing a PlaybackStream

Browse source 
This will ensure that we don't leak any memory while playing back
audio.

There is an expectation value in the test that is only set to true when
PulseAudio is present for the moment. When any new implementation is
added for other libraries/platforms, we should hopefully get a CI
failure due to unexpected success in creating the `PlaybackStream`.

To ensure that we clean up our PulseAudio connection whenever audio
output is not needed, add `PulseAudioContext::weak_instance()` to allow
us to check whether an instance exists without creating one.
This commit is contained in:
Zaggy1024 2023-08-06 01:59:47 -05:00 • committed by Andrew Kaster
parent 515b255fa4
commit 50c73d02f0
5 changed files with 58 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Tests/LibAudio/TestPlaybackStream.cpp Normal file
View file

@ -0,0 +1,44 @@
/*
* Copyright (c) 2023, Gregory Bertilson <zaggy1024@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Math.h>
#include <AK/MemoryStream.h>
#include <AK/WeakPtr.h>
#include <LibAudio/PlaybackStream.h>
#include <LibTest/TestSuite.h>
#include <unistd.h>
#if defined(HAVE_PULSEAUDIO)
# include <LibAudio/PulseAudioWrappers.h>
#endif
TEST_CASE(create_and_destroy_playback_stream)
{
bool has_implementation = false;
#if defined(HAVE_PULSEAUDIO)
has_implementation = true;
#endif
{
auto stream_result = Audio::PlaybackStream::create(Audio::OutputState::Playing, 44100, 2, 100, [](Bytes buffer, Audio::PcmSampleFormat format, size_t sample_count) -> ReadonlyBytes {
VERIFY(format == Audio::PcmSampleFormat::Float32);
FixedMemoryStream writing_stream { buffer };
for (size_t i = 0; i < sample_count; i++) {
MUST(writing_stream.write_value(0.0f));
MUST(writing_stream.write_value(0.0f));
}
return buffer.trim(writing_stream.offset());
});
EXPECT_EQ(!stream_result.is_error(), has_implementation);
usleep(10000);
}
#if defined(HAVE_PULSEAUDIO)
VERIFY(!Audio::PulseAudioContext::weak_instance());
#endif
}