From 50cf4e6e64d1e0eb8f7a40b30d560e75ed608e54 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Wed, 27 Apr 2022 12:41:18 +0200 Subject: [PATCH] LibCore: Simplify conditional logic in SharedCircularQueue No functional changes. --- Userland/Libraries/LibCore/SharedCircularQueue.h | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/Userland/Libraries/LibCore/SharedCircularQueue.h b/Userland/Libraries/LibCore/SharedCircularQueue.h index fa4bb01edf..3b89d60e9c 100644 --- a/Userland/Libraries/LibCore/SharedCircularQueue.h +++ b/Userland/Libraries/LibCore/SharedCircularQueue.h @@ -115,15 +115,12 @@ public: ErrorOr result; while (true) { result = try_enqueue(to_insert); - - if (result.is_error()) { - if (result.error() == QueueStatus::Full) - wait_function(); - else - return Error::from_string_literal("Unexpected error while enqueuing"sv); - } else { + if (!result.is_error()) break; - } + if (result.error() != QueueStatus::Full) + return Error::from_string_literal("Unexpected error while enqueuing"sv); + + wait_function(); } return {}; }