RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 13:17:34 +00:00
Code Issues Activity Actions

LibJS: Let Shape store a Realm instead of a GlobalObject

Browse source 
This is a cautious first step towards being able to create JS objects
before a global object has been instantiated.
This commit is contained in:
Andreas Kling 2022-08-01 20:27:20 +02:00
parent 7a6935a2ff
commit 50d951aea2
22 changed files with 104 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -50,8 +50,9 @@
namespace Web::Bindings {
WindowObject::WindowObject(HTML::Window& impl)
: m_impl(impl)
WindowObject::WindowObject(JS::Realm& realm, HTML::Window& impl)
: GlobalObject(realm)
, m_impl(impl)
{
impl.set_wrapper({}, *this);
}

2
Userland/Libraries/LibWeb/Bindings/WindowObject.h
View file

@ -32,7 +32,7 @@ class WindowObject
JS_OBJECT(WindowObject, JS::GlobalObject);
public:
explicit WindowObject(HTML::Window&);
explicit WindowObject(JS::Realm&, HTML::Window&);
virtual void initialize_global_object() override;
virtual ~WindowObject() override = default;

2
Userland/Libraries/LibWeb/HTML/Worker.cpp
View file

@ -113,7 +113,7 @@ void Worker::run_a_worker(AK::URL& url, EnvironmentSettingsObject& outside_setti
// FIXME: Make and use subclasses of WorkerGlobalScope, however this requires JS::GlobalObject to
// play nicely with the IDL interpreter, to make spec-compliant extensions, which it currently does not.
m_worker_scope = m_worker_vm->heap().allocate_without_global_object<JS::GlobalObject>();
m_worker_scope = m_worker_vm->heap().allocate_without_global_object<JS::GlobalObject>(*m_worker_realm);
m_worker_scope->initialize_global_object();
m_console = adopt_ref(*new WorkerDebugConsoleClient(m_worker_scope->console()));