RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:07:44 +00:00
Code Issues Activity Actions

Profiler: Get perfcore file from ArgsParser

Browse source 
Fixes #5641.
This commit is contained in:
Linus Groh 2021-03-04 23:07:38 +01:00 • committed by Andreas Kling
parent 15b675a804
commit 50ea0c3500
1 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/DevTools/Profiler/main.cpp
View file

@ -37,7 +37,6 @@
#include <LibGUI/Application.h> #include <LibGUI/Application.h>
#include <LibGUI/BoxLayout.h> #include <LibGUI/BoxLayout.h>
#include <LibGUI/Button.h> #include <LibGUI/Button.h>
#include <LibGUI/Desktop.h>
#include <LibGUI/Label.h> #include <LibGUI/Label.h>
#include <LibGUI/Menu.h> #include <LibGUI/Menu.h>
#include <LibGUI/MenuBar.h> #include <LibGUI/MenuBar.h>
@ -50,31 +49,37 @@
#include <LibGUI/TreeView.h> #include <LibGUI/TreeView.h>
#include <LibGUI/Window.h> #include <LibGUI/Window.h>
#include <serenity.h> #include <serenity.h>
#include <stdio.h>
#include <string.h> #include <string.h>
static bool generate_profile(pid_t& pid); static bool generate_profile(pid_t& pid);
int main(int argc, char** argv) int main(int argc, char** argv)
{ {
Core::ArgsParser args_parser;
int pid = 0; int pid = 0;
const char* perfcore_file_arg = nullptr;
Core::ArgsParser args_parser;
args_parser.add_option(pid, "PID to profile", "pid", 'p', "PID"); args_parser.add_option(pid, "PID to profile", "pid", 'p', "PID");
args_parser.parse(argc, argv, false); args_parser.add_positional_argument(perfcore_file_arg, "Path of perfcore file", "perfcore-file", Core::ArgsParser::Required::No);
args_parser.parse(argc, argv);
if (pid && perfcore_file_arg) {
warnln("-p/--pid option and perfcore-file argument must not be used together!");
return 1;
}
auto app = GUI::Application::construct(argc, argv); auto app = GUI::Application::construct(argc, argv);
auto app_icon = GUI::Icon::default_icon("app-profiler"); auto app_icon = GUI::Icon::default_icon("app-profiler");
String path; String perfcore_file;
if (argc != 2) { if (!perfcore_file_arg) {
if (!generate_profile(pid)) if (!generate_profile(pid))
return 0; return 0;
path = String::formatted("/proc/{}/perf_events", pid); perfcore_file = String::formatted("/proc/{}/perf_events", pid);
} else { } else {
path = argv[1]; perfcore_file = perfcore_file_arg;
} }
auto profile_or_error = Profile::load_from_perfcore_file(path); auto profile_or_error = Profile::load_from_perfcore_file(perfcore_file);
if (profile_or_error.is_error()) { if (profile_or_error.is_error()) {
GUI::MessageBox::show(nullptr, profile_or_error.error(), "Profiler", GUI::MessageBox::Type::Error); GUI::MessageBox::show(nullptr, profile_or_error.error(), "Profiler", GUI::MessageBox::Type::Error);
return 0; return 0;