RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:57:35 +00:00
Code Issues Activity Actions

AK: Rename CaseInsensitiveStringViewTraits to reflect intent

Browse source 
Now it is called `CaseInsensitiveASCIIStringViewTraits`, so we can be
more specific about what data structure does it operate onto. ;)
This commit is contained in:
gustrb 2023-03-14 08:40:53 -03:00 • committed by Linus Groh
parent 8ba6cd6ab9
commit 5141c86587
7 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/AK/TestHashMap.cpp
View file

@ -111,7 +111,7 @@ TEST_CASE(case_insensitive)
TEST_CASE(case_insensitive_stringview)
{
HashMap<StringView, int, CaseInsensitiveStringViewTraits> casemap;
HashMap<StringView, int, CaseInsensitiveASCIIStringViewTraits> casemap;
EXPECT_EQ(casemap.set("nickserv"sv, 3), AK::HashSetResult::InsertedNewEntry);
EXPECT_EQ(casemap.set("NickServ"sv, 3), AK::HashSetResult::ReplacedExistingEntry);
EXPECT_EQ(casemap.size(), 1u);

6
Tests/AK/TestStringView.cpp
View file

@ -196,7 +196,7 @@ TEST_CASE(case_insensitive_hash)
auto string3 = "aBcDeF"sv;
auto string4 = "foo"sv;
EXPECT_EQ(CaseInsensitiveStringViewTraits::hash(string1), CaseInsensitiveStringViewTraits::hash(string2));
EXPECT_EQ(CaseInsensitiveStringViewTraits::hash(string1), CaseInsensitiveStringViewTraits::hash(string3));
EXPECT_NE(CaseInsensitiveStringViewTraits::hash(string1), CaseInsensitiveStringViewTraits::hash(string4));
EXPECT_EQ(CaseInsensitiveASCIIStringViewTraits::hash(string1), CaseInsensitiveASCIIStringViewTraits::hash(string2));
EXPECT_EQ(CaseInsensitiveASCIIStringViewTraits::hash(string1), CaseInsensitiveASCIIStringViewTraits::hash(string3));
EXPECT_NE(CaseInsensitiveASCIIStringViewTraits::hash(string1), CaseInsensitiveASCIIStringViewTraits::hash(string4));
}