From 516d2f4892d98fc27814685bfc4af096eee029d4 Mon Sep 17 00:00:00 2001 From: Lucas CHOLLET Date: Sun, 12 Mar 2023 22:30:40 -0400 Subject: [PATCH] image: Add an argument to choose to write PPMs in binary or in ASCII --- Userland/Utilities/image.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Userland/Utilities/image.cpp b/Userland/Utilities/image.cpp index 7b3ec04782..2d93854d39 100644 --- a/Userland/Utilities/image.cpp +++ b/Userland/Utilities/image.cpp @@ -23,6 +23,9 @@ ErrorOr serenity_main(Main::Arguments arguments) StringView out_path; args_parser.add_option(out_path, "Path to output image file", "output", 'o', "FILE"); + bool ppm_ascii; + args_parser.add_option(ppm_ascii, "Convert to a PPM in ASCII", "ppm-ascii", {}); + args_parser.parse(arguments); if (out_path.is_empty()) { @@ -43,7 +46,8 @@ ErrorOr serenity_main(Main::Arguments arguments) } else if (out_path.ends_with(".png"sv, CaseSensitivity::CaseInsensitive)) { bytes = TRY(Gfx::PNGWriter::encode(*frame)); } else if (out_path.ends_with(".ppm"sv, CaseSensitivity::CaseInsensitive)) { - bytes = TRY(Gfx::PortableFormatWriter::encode(*frame)); + auto const format = ppm_ascii ? Gfx::PortableFormatWriter::Options::Format::ASCII : Gfx::PortableFormatWriter::Options::Format::Raw; + bytes = TRY(Gfx::PortableFormatWriter::encode(*frame, Gfx::PortableFormatWriter::Options { .format = format })); } else if (out_path.ends_with(".qoi"sv, CaseSensitivity::CaseInsensitive)) { bytes = TRY(Gfx::QOIWriter::encode(*frame)); } else {