RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

LibJS: Add spec comments to sub()

Browse source
This commit is contained in:
Linus Groh 2022-12-10 00:07:53 +00:00
parent d5359164b1
commit 51cdf2cdef
1 changed files with 25 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -1729,18 +1729,37 @@ ThrowCompletionOr<Value> add(VM& vm, Value lhs, Value rhs)
} }
// 13.8.2 The Subtraction Operator ( - ), https://tc39.es/ecma262/#sec-subtraction-operator-minus // 13.8.2 The Subtraction Operator ( - ), https://tc39.es/ecma262/#sec-subtraction-operator-minus
// AdditiveExpression : AdditiveExpression - MultiplicativeExpression
ThrowCompletionOr<Value> sub(VM& vm, Value lhs, Value rhs) ThrowCompletionOr<Value> sub(VM& vm, Value lhs, Value rhs)
{ {
// 13.15.3 ApplyStringOrNumericBinaryOperator ( lval, opText, rval ), https://tc39.es/ecma262/#sec-applystringornumericbinaryoperator
// 1-2, 6. N/A.
// 3. Let lnum be ? ToNumeric(lval).
auto lhs_numeric = TRY(lhs.to_numeric(vm)); auto lhs_numeric = TRY(lhs.to_numeric(vm));
// 4. Let rnum be ? ToNumeric(rval).
auto rhs_numeric = TRY(rhs.to_numeric(vm)); auto rhs_numeric = TRY(rhs.to_numeric(vm));
// 7. Let operation be the abstract operation associated with opText and Type(lnum) in the following table:
// [...]
// 8. Return operation(lnum, rnum).
if (both_number(lhs_numeric, rhs_numeric)) { if (both_number(lhs_numeric, rhs_numeric)) {
double lhsd = lhs_numeric.as_double(); // 6.1.6.1.8 Number::subtract ( x, y ), https://tc39.es/ecma262/#sec-numeric-types-number-subtract
double rhsd = rhs_numeric.as_double(); auto x = lhs_numeric.as_double();
double interm = lhsd - rhsd; auto y = rhs_numeric.as_double();
return Value(interm); // 1. Return Number::add(x, Number::unaryMinus(y)).
return Value(x - y);
} }
if (both_bigint(lhs_numeric, rhs_numeric)) if (both_bigint(lhs_numeric, rhs_numeric)) {
return BigInt::create(vm, lhs_numeric.as_bigint().big_integer().minus(rhs_numeric.as_bigint().big_integer())); // 6.1.6.2.8 BigInt::subtract ( x, y ), https://tc39.es/ecma262/#sec-numeric-types-bigint-subtract
auto x = lhs_numeric.as_bigint().big_integer();
auto y = rhs_numeric.as_bigint().big_integer();
// 1. Return the BigInt value that represents the difference x minus y.
return BigInt::create(vm, x.minus(y));
}
// 5. If Type(lnum) is different from Type(rnum), throw a TypeError exception.
return vm.throw_completion<TypeError>(ErrorType::BigIntBadOperatorOtherType, "subtraction"); return vm.throw_completion<TypeError>(ErrorType::BigIntBadOperatorOtherType, "subtraction");
} }