RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:47:45 +00:00
Code Issues Activity Actions

LibWeb: Delete LegacyPlatformObject and move behavior to PlatformObject

Browse source 
We have two known PlatformObjects that need to implement some of the
behavior of LegacyPlatformObjects to date: Window, and HTMLFormElement.

To make this not require double (or virtual) inheritance of
PlatformObject, move the behavior of LegacyPlatformObject into
PlatformObject. The selection of LegacyPlatformObject behavior is done
with a new bitfield of feature flags instead of a dozen virtual
functions that return bool. This change simplifies every class involved
in the diff with the notable exception of Window, which now needs some
ugly const casts to implement named property access.
This commit is contained in:
Andrew Kaster 2024-01-09 16:05:03 -07:00 • committed by Andreas Kling
parent 6047f1adcb
commit 521ed0e911
41 changed files with 684 additions and 801 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibWeb/DOM/NodeList.h
View file

@ -7,13 +7,13 @@
#pragma once
#include <LibWeb/Bindings/LegacyPlatformObject.h>
#include <LibWeb/Bindings/PlatformObject.h>
namespace Web::DOM {
// https://dom.spec.whatwg.org/#nodelist
class NodeList : public Bindings::LegacyPlatformObject {
WEB_PLATFORM_OBJECT(NodeList, Bindings::LegacyPlatformObject);
class NodeList : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(NodeList, Bindings::PlatformObject);
public:
virtual ~NodeList() override;
@ -28,19 +28,6 @@ protected:
explicit NodeList(JS::Realm&);
virtual void initialize(JS::Realm&) override;
// ^Bindings::LegacyPlatformObject
virtual bool supports_indexed_properties() const final override { return true; }
virtual bool supports_named_properties() const final override { return false; }
virtual bool has_indexed_property_setter() const final override { return false; }
virtual bool has_named_property_setter() const final override { return false; }
virtual bool has_named_property_deleter() const final override { return false; }
virtual bool has_legacy_override_built_ins_interface_extended_attribute() const final override { return false; }
virtual bool has_legacy_unenumerable_named_properties_interface_extended_attribute() const final override { return false; }
virtual bool has_global_interface_extended_attribute() const final override { return false; }
virtual bool indexed_property_setter_has_identifier() const final override { return false; }
virtual bool named_property_setter_has_identifier() const final override { return false; }
virtual bool named_property_deleter_has_identifier() const final override { return false; }
};
}