RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:57:35 +00:00
Code Issues Activity Actions

LibJS: Implement missing checks for SharedArrayBuffer values

Browse source
This commit is contained in:
Timothy Flynn 2023-12-28 09:27:42 -05:00 • committed by Andreas Kling
parent 299c86db20
commit 526a74f2f1
6 changed files with 46 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Tests/builtins/ArrayBuffer/ArrayBuffer.prototype.slice.js
View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called on SharedArrayBuffer object", () => {
expect(() => {
ArrayBuffer.prototype.slice.call(new SharedArrayBuffer());
}).toThrowWithMessage(TypeError, "The array buffer object cannot be a SharedArrayBuffer");
});
});
test("single parameter", () => {
const buffer = new ArrayBuffer(16);
const fullView = new Int32Array(buffer);

15
Userland/Libraries/LibJS/Tests/builtins/SharedArrayBuffer/SharedArrayBuffer.prototype.byteLength.js
View file

@ -1,3 +1,18 @@
describe("errors", () => {
test("called on non-SharedArrayBuffer object", () => {
expect(() => {
SharedArrayBuffer.prototype.byteLength;
}).toThrowWithMessage(TypeError, "Not an object of type SharedArrayBuffer");
let byteLength = Object.getOwnPropertyDescriptor(SharedArrayBuffer.prototype, "byteLength");
let getter = byteLength.get;
expect(() => {
getter.call(new ArrayBuffer());
}).toThrowWithMessage(TypeError, "The array buffer object must be a SharedArrayBuffer");
});
});
test("basic functionality", () => {
expect(new SharedArrayBuffer().byteLength).toBe(0);
expect(new SharedArrayBuffer(1).byteLength).toBe(1);

12
Userland/Libraries/LibJS/Tests/builtins/SharedArrayBuffer/SharedArrayBuffer.prototype.slice.js
View file

@ -1,3 +1,15 @@
describe("errors", () => {
test("called on non-SharedArrayBuffer object", () => {
expect(() => {
SharedArrayBuffer.prototype.slice(Symbol.hasInstance);
}).toThrowWithMessage(TypeError, "Not an object of type SharedArrayBuffer");
expect(() => {
SharedArrayBuffer.prototype.slice.call(new ArrayBuffer());
}).toThrowWithMessage(TypeError, "The array buffer object must be a SharedArrayBuffer");
});
});
test("single parameter", () => {
const buffer = new SharedArrayBuffer(16);
const fullView = new Int32Array(buffer);