From 5275a1101e9b305d6a6a7d82d4f778a8c2d9c8b1 Mon Sep 17 00:00:00 2001 From: Zaggy1024 Date: Tue, 22 Nov 2022 02:21:06 -0600 Subject: [PATCH] LibVideo/VP9: Remove dump_frame_info() function from Decoder The function serves no purpose now, any debug information we want to pull from the decoder should be instead accessed by some other yet to be created interface. --- Userland/Libraries/LibVideo/VP9/Decoder.cpp | 5 ----- Userland/Libraries/LibVideo/VP9/Decoder.h | 1 - Userland/Libraries/LibVideo/VP9/Parser.cpp | 8 -------- Userland/Libraries/LibVideo/VP9/Parser.h | 1 - 4 files changed, 15 deletions(-) diff --git a/Userland/Libraries/LibVideo/VP9/Decoder.cpp b/Userland/Libraries/LibVideo/VP9/Decoder.cpp index b2dd0176b2..f658724e92 100644 --- a/Userland/Libraries/LibVideo/VP9/Decoder.cpp +++ b/Userland/Libraries/LibVideo/VP9/Decoder.cpp @@ -46,11 +46,6 @@ DecoderErrorOr Decoder::receive_sample(ReadonlyBytes chunk_data) return {}; } -void Decoder::dump_frame_info() -{ - m_parser->dump_info(); -} - inline size_t index_from_row_and_column(u32 row, u32 column, u32 stride) { return row * stride + column; diff --git a/Userland/Libraries/LibVideo/VP9/Decoder.h b/Userland/Libraries/LibVideo/VP9/Decoder.h index 7985686170..673ba249f1 100644 --- a/Userland/Libraries/LibVideo/VP9/Decoder.h +++ b/Userland/Libraries/LibVideo/VP9/Decoder.h @@ -29,7 +29,6 @@ public: ~Decoder() override { } /* (8.1) General */ DecoderErrorOr receive_sample(ReadonlyBytes) override; - void dump_frame_info(); DecoderErrorOr> get_decoded_frame() override; diff --git a/Userland/Libraries/LibVideo/VP9/Parser.cpp b/Userland/Libraries/LibVideo/VP9/Parser.cpp index 1dbfb417df..9a4741d509 100644 --- a/Userland/Libraries/LibVideo/VP9/Parser.cpp +++ b/Userland/Libraries/LibVideo/VP9/Parser.cpp @@ -1687,12 +1687,4 @@ void Parser::append_sub8x8_mvs(i32 block, u8 ref_list) m_near_mv[ref_list] = sub_8x8_mvs[1]; } -void Parser::dump_info() -{ - outln("Frame dimensions: {}x{}", m_frame_size.width(), m_frame_size.height()); - outln("Render dimensions: {}x{}", m_render_size.width(), m_render_size.height()); - outln("Bit depth: {}", m_bit_depth); - outln("Show frame: {}", m_show_frame); -} - } diff --git a/Userland/Libraries/LibVideo/VP9/Parser.h b/Userland/Libraries/LibVideo/VP9/Parser.h index a6e040de1d..87dd01e7bd 100644 --- a/Userland/Libraries/LibVideo/VP9/Parser.h +++ b/Userland/Libraries/LibVideo/VP9/Parser.h @@ -35,7 +35,6 @@ public: explicit Parser(Decoder&); ~Parser(); DecoderErrorOr parse_frame(ReadonlyBytes); - void dump_info(); private: /* Annex B: Superframes are a method of storing multiple coded frames into a single chunk