RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 12:37:40 +00:00
Code Issues Activity Actions

LibWeb: Remove old FIXMEs about not setting up the navigation API's NHEs

Browse source
This commit is contained in:
Andrew Kaster 2023-09-27 23:01:23 -06:00 • committed by Alexander Kalenik
parent 6c1944ee61
commit 52a9a8146b
1 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -116,10 +116,8 @@ JS::GCPtr<NavigationHistoryEntry> Navigation::current_entry() const
if (has_entries_and_events_disabled()) if (has_entries_and_events_disabled())
return nullptr; return nullptr;
// FIXME 2. Assert: navigation's current entry index is not −1. // 2. Assert: navigation's current entry index is not −1.
// FIXME: This should not happen once Navigable's algorithms properly set up NHEs. VERIFY(m_current_entry_index != -1);
if (m_current_entry_index == -1)
return nullptr;
// 3. Return navigation's entry list[navigation's current entry index]. // 3. Return navigation's entry list[navigation's current entry index].
return m_entry_list[m_current_entry_index]; return m_entry_list[m_current_entry_index];
@ -162,10 +160,8 @@ bool Navigation::can_go_back() const
if (has_entries_and_events_disabled()) if (has_entries_and_events_disabled())
return false; return false;
// FIXME 2. Assert: navigation's current entry index is not −1. // 2. Assert: navigation's current entry index is not −1.
// FIXME: This should not happen once Navigable's algorithms properly set up NHEs. VERIFY(m_current_entry_index != -1);
if (m_current_entry_index == -1)
return false;
// 3. If this's current entry index is 0, then return false. // 3. If this's current entry index is 0, then return false.
// 4. Return true. // 4. Return true.
@ -181,10 +177,8 @@ bool Navigation::can_go_forward() const
if (has_entries_and_events_disabled()) if (has_entries_and_events_disabled())
return false; return false;
// FIXME 2. Assert: navigation's current entry index is not −1. // 2. Assert: navigation's current entry index is not −1.
// FIXME: This should not happen once Navigable's algorithms properly set up NHEs. VERIFY(m_current_entry_index != -1);
if (m_current_entry_index == -1)
return false;
// 3. If this's current entry index is equal to this's entry list's size, then return false. // 3. If this's current entry index is equal to this's entry list's size, then return false.
// 4. Return true. // 4. Return true.