RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:17:44 +00:00
Code Issues Activity Actions

LibWeb: Make factory method of Crypto::SubtleCrypto fallible

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-12 21:25:57 +01:00 • committed by Linus Groh
parent 58af8e2021
commit 52e9839d8b
3 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Crypto/Crypto.cpp
View file

@ -8,6 +8,7 @@
#include <AK/Random.h>
#include <AK/StringBuilder.h>
#include <LibJS/Runtime/TypedArray.h>
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Crypto/Crypto.h>
#include <LibWeb/Crypto/SubtleCrypto.h>
@ -30,7 +31,9 @@ JS::ThrowCompletionOr<void> Crypto::initialize(JS::Realm& realm)
{
MUST_OR_THROW_OOM(Base::initialize(realm));
set_prototype(&Bindings::ensure_web_prototype<Bindings::CryptoPrototype>(realm, "Crypto"));
m_subtle = SubtleCrypto::create(realm);
m_subtle = TRY(Bindings::throw_dom_exception_if_needed(realm.vm(), [&]() {
return SubtleCrypto::create(realm);
}));
return {};
}

6
Userland/Libraries/LibWeb/Crypto/SubtleCrypto.cpp
View file

@ -10,13 +10,13 @@
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Crypto/SubtleCrypto.h>
#include <LibWeb/WebIDL/AbstractOperations.h>
#include <LibWeb/WebIDL/DOMException.h>
#include <LibWeb/WebIDL/ExceptionOr.h>
namespace Web::Crypto {
JS::NonnullGCPtr<SubtleCrypto> SubtleCrypto::create(JS::Realm& realm)
WebIDL::ExceptionOr<JS::NonnullGCPtr<SubtleCrypto>> SubtleCrypto::create(JS::Realm& realm)
{
return realm.heap().allocate<SubtleCrypto>(realm, realm).release_allocated_value_but_fixme_should_propagate_errors();
return MUST_OR_THROW_OOM(realm.heap().allocate<SubtleCrypto>(realm, realm));
}
SubtleCrypto::SubtleCrypto(JS::Realm& realm)

2
Userland/Libraries/LibWeb/Crypto/SubtleCrypto.h
View file

@ -15,7 +15,7 @@ class SubtleCrypto final : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(SubtleCrypto, Bindings::PlatformObject);
public:
static JS::NonnullGCPtr<SubtleCrypto> create(JS::Realm&);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<SubtleCrypto>> create(JS::Realm&);
virtual ~SubtleCrypto() override;