RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:07:34 +00:00
Code Issues Activity Actions

LibJS: Handle empty values in Array.prototype.toString()

Browse source
This commit is contained in:
Linus Groh 2020-04-08 18:56:12 +01:00 • committed by Andreas Kling
parent 5c90cfa90f
commit 531335f57c
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -100,7 +100,8 @@ Value ArrayPrototype::to_string(Interpreter& interpreter)
for (size_t i = 0; i < array->elements().size(); ++i) { for (size_t i = 0; i < array->elements().size(); ++i) {
if (i != 0) if (i != 0)
builder.append(','); builder.append(',');
builder.append(array->elements()[i].to_string()); if (!array->elements()[i].is_empty())
builder.append(array->elements()[i].to_string());
} }
return js_string(interpreter, builder.to_string()); return js_string(interpreter, builder.to_string());
} }

6
Libraries/LibJS/Tests/Array.prototype.toString.js
View file

@ -6,6 +6,12 @@ try {
assert("rgb(" + [10, 11, 12] + ")" === "rgb(10,11,12)"); assert("rgb(" + [10, 11, 12] + ")" === "rgb(10,11,12)");
a = new Array(5);
assert(a.toString() === ",,,,");
a[2] = "foo";
a[4] = "bar";
assert(a.toString() === ",,foo,,bar");
console.log("PASS"); console.log("PASS");
} catch (e) { } catch (e) {
console.log("FAIL: " + e); console.log("FAIL: " + e);