RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:48:14 +00:00
Code Issues Activity Actions

LibJS: Prefer "define_property" over "put"

Browse source
This commit is contained in:
Matthew Olsson 2020-07-11 07:58:56 -07:00 • committed by Andreas Kling
parent c485c86015
commit 531fdb2e82
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -182,7 +182,7 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayPrototype::map)
for_each_item(interpreter, global_object, "map", [&](auto index, auto, auto callback_result) { for_each_item(interpreter, global_object, "map", [&](auto index, auto, auto callback_result) {
if (interpreter.exception()) if (interpreter.exception())
return IterationDecision::Break; return IterationDecision::Break;
new_array->put(index, callback_result); new_array->define_property(index, callback_result);
return IterationDecision::Continue; return IterationDecision::Continue;
}); });
return Value(new_array); return Value(new_array);

4
Libraries/LibJS/Runtime/IteratorOperations.cpp
View file

@ -112,8 +112,8 @@ void iterator_close(Object& iterator)
Value create_iterator_result_object(Interpreter& interpreter, GlobalObject& global_object, Value value, bool done) Value create_iterator_result_object(Interpreter& interpreter, GlobalObject& global_object, Value value, bool done)
{ {
auto* object = Object::create_empty(interpreter, global_object); auto* object = Object::create_empty(interpreter, global_object);
object->put("value", value); object->define_property("value", value);
object->put("done", Value(done)); object->define_property("done", Value(done));
return object; return object;
} }

4
Libraries/LibJS/Runtime/JSONObject.cpp
View file

@ -433,7 +433,7 @@ Object* JSONObject::parse_json_object(Interpreter& interpreter, GlobalObject& gl
{ {
auto* object = Object::create_empty(interpreter, global_object); auto* object = Object::create_empty(interpreter, global_object);
json_object.for_each_member([&](auto& key, auto& value) { json_object.for_each_member([&](auto& key, auto& value) {
object->put(key, parse_json_value(interpreter, global_object, value)); object->define_property(key, parse_json_value(interpreter, global_object, value));
}); });
return object; return object;
} }
@ -443,7 +443,7 @@ Array* JSONObject::parse_json_array(Interpreter& interpreter, GlobalObject& glob
auto* array = Array::create(global_object); auto* array = Array::create(global_object);
size_t index = 0; size_t index = 0;
json_array.for_each([&](auto& value) { json_array.for_each([&](auto& value) {
array->put(index++, parse_json_value(interpreter, global_object, value)); array->define_property(index++, parse_json_value(interpreter, global_object, value));
}); });
return array; return array;
} }