RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:27:35 +00:00
Code Issues Activity Actions

LibWeb: Allow Angle/Frequency/Resolution/Time values for CSS properties

Browse source
This commit is contained in:
Sam Atkins 2022-02-22 13:49:05 +00:00 • committed by Andreas Kling
parent 5c8ea81d21
commit 53a3937c34
1 changed files with 30 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

37
Meta/Lagom/Tools/CodeGenerators/LibWeb/Generate_CSS_PropertyID_cpp.cpp
View file

@ -295,10 +295,22 @@ bool property_accepts_value(PropertyID property_id, StyleValue& style_value)
auto type_parts = type.as_string().split_view(' ');
auto type_name = type_parts.first();
auto type_args = type_parts.size() > 1 ? type_parts[1] : ""sv;
if (type_name == "color") {
if (type_name == "angle") {
property_generator.append(R"~~~(
if (style_value.is_angle()
|| (style_value.is_calculated() && style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Angle))
return true;
)~~~");
} else if (type_name == "color") {
property_generator.append(R"~~~(
if (style_value.has_color())
return true;
)~~~");
} else if (type_name == "frequency") {
property_generator.append(R"~~~(
if (style_value.is_frequency()
|| (style_value.is_calculated() && style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Frequency))
return true;
)~~~");
} else if (type_name == "image") {
property_generator.append(R"~~~(
@ -310,12 +322,6 @@ bool property_accepts_value(PropertyID property_id, StyleValue& style_value)
if (style_value.has_length()
|| (style_value.is_calculated() && style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Length))
return true;
)~~~");
} else if (type_name == "percentage") {
property_generator.append(R"~~~(
if (style_value.is_percentage()
|| (style_value.is_calculated() && style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Percentage))
return true;
)~~~");
} else if (type_name == "number" || type_name == "integer") {
auto test_generator = property_generator.fork();
@ -344,11 +350,28 @@ bool property_accepts_value(PropertyID property_id, StyleValue& style_value)
test_generator.append(R"~~~(|| style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Number)~~~");
test_generator.append(R"~~~()))
return true;
)~~~");
} else if (type_name == "percentage") {
property_generator.append(R"~~~(
if (style_value.is_percentage()
|| (style_value.is_calculated() && style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Percentage))
return true;
)~~~");
} else if (type_name == "resolution") {
property_generator.append(R"~~~(
if (style_value.is_resolution())
return true;
)~~~");
} else if (type_name == "string") {
property_generator.append(R"~~~(
if (style_value.is_string())
return true;
)~~~");
} else if (type_name == "time") {
property_generator.append(R"~~~(
if (style_value.is_time()
|| (style_value.is_calculated() && style_value.as_calculated().resolved_type() == CalculatedStyleValue::ResolvedType::Time))
return true;
)~~~");
} else if (type_name == "url") {
// FIXME: Handle urls!