RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 20:57:41 +00:00
Code Issues Activity Actions

LibJS: Fix casting a value to ScriptFunction without checking it's one

Browse source
This commit is contained in:
Sergey Bugaev 2020-06-01 16:58:54 +03:00 • committed by Andreas Kling
parent 1274c244d5
commit 53a94b8bbd
3 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/AST.cpp
View file

@ -52,9 +52,9 @@ static void update_function_name(Value& value, const FlyString& name)
return; return;
auto& object = value.as_object(); auto& object = value.as_object();
if (object.is_function()) { if (object.is_function()) {
auto& function = static_cast<ScriptFunction&>(object); auto& function = static_cast<Function&>(object);
if (function.name().is_empty()) if (function.is_script_function() && function.name().is_empty())
function.set_name(name); static_cast<ScriptFunction&>(function).set_name(name);
} else if (object.is_array()) { } else if (object.is_array()) {
auto& array = static_cast<Array&>(object); auto& array = static_cast<Array&>(object);
for (auto& entry : array.indexed_properties().values_unordered()) for (auto& entry : array.indexed_properties().values_unordered())

2
Libraries/LibJS/Runtime/Function.h
View file

@ -42,6 +42,8 @@ public:
virtual void visit_children(Visitor&) override; virtual void visit_children(Visitor&) override;
virtual bool is_script_function() const { return false; }
BoundFunction* bind(Value bound_this_value, Vector<Value> arguments); BoundFunction* bind(Value bound_this_value, Vector<Value> arguments);
Value bound_this() const Value bound_this() const

2
Libraries/LibJS/Runtime/ScriptFunction.h
View file

@ -48,7 +48,7 @@ public:
void set_name(const FlyString& name) { m_name = name; }; void set_name(const FlyString& name) { m_name = name; };
private: private:
virtual bool is_script_function() const final { return true; } virtual bool is_script_function() const override { return true; }
virtual const char* class_name() const override { return "ScriptFunction"; } virtual const char* class_name() const override { return "ScriptFunction"; }
virtual LexicalEnvironment* create_environment() override; virtual LexicalEnvironment* create_environment() override;
virtual void visit_children(Visitor&) override; virtual void visit_children(Visitor&) override;