RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

Kernel: Rename some ProcessorInfo members to match Intel manual

Browse source 
Let's use terminology from the the Intel manual to avoid confusion.
Also add `_string` suffixes to better distinguish the numeric values
from the string values.
This commit is contained in:
Linus Groh 2022-04-03 16:38:45 +01:00 • committed by Andreas Kling
parent ebe2cf8995
commit 53a95a5347
3 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/GlobalProcessExposed.cpp
View file

@ -582,14 +582,15 @@ private:
auto& info = proc.info();
auto obj = TRY(array.add_object());
TRY(obj.add("processor", proc.id()));
TRY(obj.add("cpuid", info.cpuid()));
// FIXME: Rename this to use the same name everywhere.
TRY(obj.add("cpuid", info.vendor_id_string()));
TRY(obj.add("family", info.display_family()));
auto features_array = TRY(obj.add_array("features"));
auto keep_empty = false;
ErrorOr<void> result; // FIXME: Make this nicer
info.features().for_each_split_view(' ', keep_empty, [&](StringView feature) {
info.features_string().for_each_split_view(' ', keep_empty, [&](StringView feature) {
if (result.is_error())
return;
result = features_array.add(feature);
@ -601,7 +602,7 @@ private:
TRY(obj.add("model", info.display_model()));
TRY(obj.add("stepping", info.stepping()));
TRY(obj.add("type", info.type()));
TRY(obj.add("brand", info.brand()));
TRY(obj.add("brand", info.brand_string()));
TRY(obj.finish());
return {};