RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:17:45 +00:00
Code Issues Activity Actions

Kernel: Use StringView literals in VirtIO::determine_device_class()

Browse source 
Since the return type is StringView we can just create them at compile
time and avoid the run-time construction.
This commit is contained in:
Idan Horowitz 2021-09-19 21:02:53 +03:00 • committed by Andreas Kling
parent 35116c9117
commit 53cf28c47c
1 changed files with 15 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Kernel/Bus/VirtIO/Device.cpp
View file

@ -54,34 +54,36 @@ StringView determine_device_class(const PCI::Address& address)
auto subsystem_device_id = PCI::get_subsystem_id(address); auto subsystem_device_id = PCI::get_subsystem_id(address);
switch (subsystem_device_id) { switch (subsystem_device_id) {
case 1: case 1:
return "VirtIONetAdapter"; return "VirtIONetAdapter"sv;
case 2: case 2:
return "VirtIOBlockDevice"; return "VirtIOBlockDevice"sv;
case 3: case 3:
return "VirtIOConsole"; return "VirtIOConsole"sv;
case 4: case 4:
return "VirtIORNG"; return "VirtIORNG"sv;
default:
dbgln("VirtIO: Unknown subsystem_device_id {}", subsystem_device_id);
VERIFY_NOT_REACHED();
} }
dbgln("VirtIO: Unknown subsystem_device_id {}", subsystem_device_id);
VERIFY_NOT_REACHED();
} }
auto id = PCI::get_id(address); auto id = PCI::get_id(address);
VERIFY(id.vendor_id == PCI::VendorID::VirtIO); VERIFY(id.vendor_id == PCI::VendorID::VirtIO);
switch (id.device_id) { switch (id.device_id) {
case PCI::DeviceID::VirtIONetAdapter: case PCI::DeviceID::VirtIONetAdapter:
return "VirtIONetAdapter"; return "VirtIONetAdapter"sv;
case PCI::DeviceID::VirtIOBlockDevice: case PCI::DeviceID::VirtIOBlockDevice:
return "VirtIOBlockDevice"; return "VirtIOBlockDevice"sv;
case PCI::DeviceID::VirtIOConsole: case PCI::DeviceID::VirtIOConsole:
return "VirtIOConsole"; return "VirtIOConsole"sv;
case PCI::DeviceID::VirtIOEntropy: case PCI::DeviceID::VirtIOEntropy:
return "VirtIORNG"; return "VirtIORNG"sv;
case PCI::DeviceID::VirtIOGPU: case PCI::DeviceID::VirtIOGPU:
return "VirtIOGPU"; return "VirtIOGPU"sv;
default:
dbgln("VirtIO: Unknown device_id {}", id.vendor_id);
VERIFY_NOT_REACHED();
} }
dbgln("VirtIO: Unknown device_id {}", id.vendor_id);
VERIFY_NOT_REACHED();
} }
UNMAP_AFTER_INIT void Device::initialize() UNMAP_AFTER_INIT void Device::initialize()