RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:47:34 +00:00
Code Issues Activity Actions

AK+Userland: Remove nullability feature for the ByteBuffer type

Browse source 
Nobody seems to use this particular feature, in fact there were some
bugs which were uncovered by removing operator bool.
This commit is contained in:
Gunnar Beutner 2021-05-16 08:47:46 +02:00 • committed by Andreas Kling
parent c4d0b0cd6b
commit 53d0150827
16 changed files with 12 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibCore/IODevice.cpp
View file

@ -33,8 +33,6 @@ const char* IODevice::error_string() const
int IODevice::read(u8* buffer, int length)
{
auto read_buffer = read(length);
if (read_buffer.is_null())
return 0;
memcpy(buffer, read_buffer.data(), length);
return read_buffer.size();
}
@ -151,8 +149,6 @@ ByteBuffer IODevice::read_all()
}
data.append((const u8*)read_buffer, nread);
}
if (data.is_empty())
return {};
return ByteBuffer::copy(data.data(), data.size());
}

2
Userland/Libraries/LibGemini/Job.cpp
View file

@ -110,7 +110,7 @@ void Job::on_socket_connected()
auto read_size = 64 * KiB;
auto payload = receive(read_size);
if (!payload) {
if (payload.is_empty()) {
if (eof()) {
finish_up();
return IterationDecision::Break;

2
Userland/Libraries/LibHTTP/Job.cpp
View file

@ -283,7 +283,7 @@ void Job::on_socket_connected()
}
auto payload = receive(read_size);
if (!payload) {
if (payload.is_empty()) {
if (eof()) {
finish_up();
return IterationDecision::Break;

4
Userland/Libraries/LibTLS/ClientHandshake.cpp
View file

@ -474,9 +474,7 @@ ssize_t TLSv12::handle_payload(ReadonlyBytes vbuffer)
}
break;
case Finished:
if (m_context.cached_handshake) {
m_context.cached_handshake.clear();
}
m_context.cached_handshake.clear();
if (m_context.handshake_messages[10] >= 1) {
dbgln("unexpected finished message");
payload_res = (i8)Error::UnexpectedMessage;

2
Userland/Libraries/LibWeb/CSS/Parser/DeprecatedCSSParser.cpp
View file

@ -431,7 +431,7 @@ public:
if (type != CSS::Selector::SimpleSelector::Type::Universal) {
while (is_valid_selector_char(peek()))
buffer.append(consume_one());
PARSE_VERIFY(!buffer.is_null());
PARSE_VERIFY(!buffer.is_empty());
}
auto value = String::copy(buffer);

2
Userland/Libraries/LibWeb/Loader/Resource.h
View file

@ -42,7 +42,7 @@ public:
bool is_failed() const { return m_failed; }
const String& error() const { return m_error; }
bool has_encoded_data() const { return !m_encoded_data.is_null(); }
bool has_encoded_data() const { return !m_encoded_data.is_empty(); }
const URL& url() const { return m_request.url(); }
const ByteBuffer& encoded_data() const { return m_encoded_data; }

2
Userland/Libraries/LibWeb/XHR/XMLHttpRequest.cpp
View file

@ -47,7 +47,7 @@ void XMLHttpRequest::fire_progress_event(const String& event_name, u64 transmitt
String XMLHttpRequest::response_text() const
{
if (m_response_object.is_null())
if (m_response_object.is_empty())
return {};
return String::copy(m_response_object);
}