RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:57:44 +00:00
Code Issues Activity Actions

LibC: Make the syscall wrappers for stat/lstat/chdir return EFAULT

Browse source 
If we pass a null path to these syscall wrappers, just return EFAULT
directly from the wrapper instead of segfaulting by calling strlen().
This is a compromise, since we now have to pass the path length to the
kernel, so we can't rely on the kernel to tell us that the path is at
a bad memory address.
This commit is contained in:
Andreas Kling 2020-01-06 10:51:50 +01:00
parent 642137f014
commit 53d3b6b0a7
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibC/unistd.cpp
View file

@ -227,12 +227,20 @@ pid_t waitpid(pid_t waitee, int* wstatus, int options)
int lstat(const char* path, struct stat* statbuf) int lstat(const char* path, struct stat* statbuf)
{ {
if (!path) {
errno = EFAULT;
return -1;
}
int rc = syscall(SC_lstat, path, strlen(path), statbuf); int rc = syscall(SC_lstat, path, strlen(path), statbuf);
__RETURN_WITH_ERRNO(rc, rc, -1); __RETURN_WITH_ERRNO(rc, rc, -1);
} }
int stat(const char* path, struct stat* statbuf) int stat(const char* path, struct stat* statbuf)
{ {
if (!path) {
errno = EFAULT;
return -1;
}
int rc = syscall(SC_stat, path, strlen(path), statbuf); int rc = syscall(SC_stat, path, strlen(path), statbuf);
__RETURN_WITH_ERRNO(rc, rc, -1); __RETURN_WITH_ERRNO(rc, rc, -1);
} }
@ -245,6 +253,10 @@ int fstat(int fd, struct stat* statbuf)
int chdir(const char* path) int chdir(const char* path)
{ {
if (!path) {
errno = EFAULT;
return -1;
}
int rc = syscall(SC_chdir, path, strlen(path)); int rc = syscall(SC_chdir, path, strlen(path));
__RETURN_WITH_ERRNO(rc, rc, -1); __RETURN_WITH_ERRNO(rc, rc, -1);
} }