RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibWeb: Explain discrepancy with media-query parsing

Browse source 
This had me confused for a while, but I am not smart enough today to
actually fix it properly. :^)
This commit is contained in:
Sam Atkins 2022-02-16 19:47:58 +00:00 • committed by Andreas Kling
parent 8e82544dce
commit 53ec2ace23
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -1124,6 +1124,9 @@ OwnPtr<MediaCondition> Parser::parse_media_in_parens(TokenStream<StyleComponentV
}
// `<general-enclosed>`
// FIXME: We should only be taking this branch if the grammar doesn't match the above options.
// Currently we take it if the above fail to parse, which is different.
// eg, `@media (min-width: 76yaks)` is valid grammar, but does not parse because `yaks` isn't a unit.
if (auto maybe_general_enclosed = parse_general_enclosed(tokens); maybe_general_enclosed.has_value())
return MediaCondition::from_general_enclosed(maybe_general_enclosed.release_value());