RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

CI: Do not expect test-results.log to exist on AArch64

Browse source 
The AArch64 port is still unstable, and in some cases, we may encounter
a kernel panic or Shell crash that prevents `test-results.log` from
being written to disk. The CI job would fail when we tried to print out
the contents of this non-existent file. We have been ignoring its
contents anyway, so let's not read it at all.
This commit is contained in:
Daniel Bertalan 2023-05-30 09:50:24 +02:00 • committed by Jelle Raaijmakers
parent 7f9ede07bc
commit 540ea9f1c4
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
.github/workflows/cmake.yml vendored
View file

@ -246,6 +246,10 @@ jobs:
echo "::group::ninja run # Qemu output" echo "::group::ninja run # Qemu output"
ninja run ninja run
echo "::endgroup::" echo "::endgroup::"
if ${{ matrix.arch == 'aarch64' }}; then
# FIXME: Actually verify test results when all tests are expected to pass.
exit 0
fi
echo "::group::Verify Output File" echo "::group::Verify Output File"
mkdir fsmount mkdir fsmount
sudo mount -t ext2 -o loop,rw _disk_image fsmount sudo mount -t ext2 -o loop,rw _disk_image fsmount
@ -253,11 +257,6 @@ jobs:
sudo cat fsmount/home/anon/test-results.log sudo cat fsmount/home/anon/test-results.log
if ! sudo grep -q "Failed: 0" fsmount/home/anon/test-results.log if ! sudo grep -q "Failed: 0" fsmount/home/anon/test-results.log
then then
if ${{ matrix.arch == 'aarch64' }}; then
# FIXME: Remove this once all tests pass on AArch64
echo "::warning:: :^( Some tests failed"
exit 0
fi
echo "::error:: :^( Tests failed, failing job" echo "::error:: :^( Tests failed, failing job"
exit 1 exit 1
fi fi