From 541579bc0433a8d46999d1a383ffc460b8f6ed02 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 23 Nov 2020 20:50:22 +0100 Subject: [PATCH] Kernel: Remove unnecessary SmapDisablers in FileDescription Since we're using UserOrKernelBuffers, SMAP will be automatically disabled when we actually access the buffer later on. There's no need to disable it wholesale across the entire read/write operations. --- Kernel/FileSystem/FileDescription.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/Kernel/FileSystem/FileDescription.cpp b/Kernel/FileSystem/FileDescription.cpp index 31216fa78f..ae38eccacd 100644 --- a/Kernel/FileSystem/FileDescription.cpp +++ b/Kernel/FileSystem/FileDescription.cpp @@ -123,7 +123,6 @@ KResultOr FileDescription::read(UserOrKernelBuffer& buffer, size_t count new_offset += count; if (new_offset.has_overflow()) return -EOVERFLOW; - SmapDisabler disabler; auto nread_or_error = m_file->read(*this, offset(), buffer, count); if (!nread_or_error.is_error() && m_file->is_seekable()) m_current_offset += nread_or_error.value(); @@ -137,7 +136,6 @@ KResultOr FileDescription::write(const UserOrKernelBuffer& data, size_t new_offset += size; if (new_offset.has_overflow()) return -EOVERFLOW; - SmapDisabler disabler; auto nwritten_or_error = m_file->write(*this, offset(), data, size); if (!nwritten_or_error.is_error() && m_file->is_seekable()) m_current_offset += nwritten_or_error.value();