From 5424372d505687504424ce657b1438aea8f2a315 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 23 May 2021 09:20:46 +0200 Subject: [PATCH] AudioServer: Remove unnecessary greet() message --- Userland/Libraries/LibAudio/ClientConnection.cpp | 1 - Userland/Services/AudioServer/AudioServer.ipc | 3 --- Userland/Services/AudioServer/ClientConnection.cpp | 4 ---- Userland/Services/AudioServer/ClientConnection.h | 1 - 4 files changed, 9 deletions(-) diff --git a/Userland/Libraries/LibAudio/ClientConnection.cpp b/Userland/Libraries/LibAudio/ClientConnection.cpp index 4f47bd41d5..d38fb532be 100644 --- a/Userland/Libraries/LibAudio/ClientConnection.cpp +++ b/Userland/Libraries/LibAudio/ClientConnection.cpp @@ -16,7 +16,6 @@ ClientConnection::ClientConnection() void ClientConnection::handshake() { - greet(); } void ClientConnection::enqueue(const Buffer& buffer) diff --git a/Userland/Services/AudioServer/AudioServer.ipc b/Userland/Services/AudioServer/AudioServer.ipc index 620c27e484..b78e683026 100644 --- a/Userland/Services/AudioServer/AudioServer.ipc +++ b/Userland/Services/AudioServer/AudioServer.ipc @@ -1,8 +1,5 @@ endpoint AudioServer { - // Basic protocol - greet() => () - // Mixer functions set_muted(bool muted) => () get_muted() => (bool muted) diff --git a/Userland/Services/AudioServer/ClientConnection.cpp b/Userland/Services/AudioServer/ClientConnection.cpp index 34ef976d73..7fcd473b59 100644 --- a/Userland/Services/AudioServer/ClientConnection.cpp +++ b/Userland/Services/AudioServer/ClientConnection.cpp @@ -59,10 +59,6 @@ void ClientConnection::did_change_main_mix_volume(Badge, int volume) async_main_mix_volume_changed(volume); } -void ClientConnection::greet() -{ -} - Messages::AudioServer::GetMainMixVolumeResponse ClientConnection::get_main_mix_volume() { return m_mixer.main_volume(); diff --git a/Userland/Services/AudioServer/ClientConnection.h b/Userland/Services/AudioServer/ClientConnection.h index 21c65fbffa..fd965b6cd6 100644 --- a/Userland/Services/AudioServer/ClientConnection.h +++ b/Userland/Services/AudioServer/ClientConnection.h @@ -35,7 +35,6 @@ public: static void for_each(Function); private: - virtual void greet() override; virtual Messages::AudioServer::GetMainMixVolumeResponse get_main_mix_volume() override; virtual void set_main_mix_volume(i32) override; virtual Messages::AudioServer::EnqueueBufferResponse enqueue_buffer(Core::AnonymousBuffer const&, i32, int) override;