RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:27:44 +00:00
Code Issues Activity Actions

LibJS: Adjust grammar for DateExtendedYear to exclude -000000

Browse source 
This is an editorial change in the Temporal spec.

See: fb3e656

We lose the custom error message, but it's not the end of the world.
This commit is contained in:
Linus Groh 2022-03-10 18:10:11 +01:00
parent 68af8649fb
commit 54af3a5396
8 changed files with 28 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js
View file

@ -53,9 +53,9 @@ describe("errors", () => {
test("extended year must not be negative zero", () => {
expect(() => {
Temporal.PlainDate.from("-000000-01-01");
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid date string '-000000-01-01'");
expect(() => {
Temporal.PlainDate.from("−000000-01-01"); // U+2212
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid date string '−000000-01-01'");
});
});

4
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.from.js
View file

@ -190,9 +190,9 @@ describe("errors", () => {
test("extended year must not be negative zero", () => {
expect(() => {
Temporal.PlainDateTime.from("-000000-01-01");
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid date time string '-000000-01-01'");
expect(() => {
Temporal.PlainDateTime.from("−000000-01-01"); // U+2212
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid date time string '−000000-01-01'");
});
});

4
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js
View file

@ -79,9 +79,9 @@ describe("errors", () => {
test("extended year must not be negative zero", () => {
expect(() => {
Temporal.PlainMonthDay.from("-000000-01-01");
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid month day string '-000000-01-01'");
expect(() => {
Temporal.PlainMonthDay.from("−000000-01-01"); // U+2212
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid month day string '−000000-01-01'");
});
});

4
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainTime/PlainTime.from.js
View file

@ -68,10 +68,10 @@ describe("errors", () => {
test("extended year must not be negative zero", () => {
expect(() => {
Temporal.PlainTime.from("-000000-01-01T00:00:00");
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid time string '-000000-01-01T00:00:00'");
expect(() => {
Temporal.PlainTime.from("−000000-01-01T00:00:00"); // U+2212
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid time string '−000000-01-01T00:00:00'");
});
test("ambiguous string must contain a time designator", () => {

6
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainYearMonth/PlainYearMonth.from.js
View file

@ -105,9 +105,9 @@ describe("errors", () => {
test("extended year must not be negative zero", () => {
expect(() => {
Temporal.PlainYearMonth.from("-000000-01");
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
}).toThrowWithMessage(RangeError, "Invalid year month string '-000000-01'");
expect(() => {
Temporal.PlainYearMonth.from("−000000-01-01"); // U+2212
}).toThrowWithMessage(RangeError, "Invalid extended year, must not be negative zero");
Temporal.PlainYearMonth.from("−000000-01"); // U+2212
}).toThrowWithMessage(RangeError, "Invalid year month string '−000000-01'");
});
});