RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:07:45 +00:00
Code Issues Activity Actions

Userland: Replace all uses of load_from_gml with try_load_from_gml

Browse source 
MOAR FIXMES! ;^)
This commit is contained in:
Sam Atkins 2023-01-07 12:33:53 +00:00 • committed by Linus Groh
parent 703da34947
commit 54b1326165
78 changed files with 94 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp
View file

@ -42,7 +42,7 @@ BackgroundSettingsWidget::BackgroundSettingsWidget(bool& background_settings_cha
void BackgroundSettingsWidget::create_frame()
{
load_from_gml(background_settings_gml);
try_load_from_gml(background_settings_gml).release_value_but_fixme_should_propagate_errors();
m_monitor_widget = *find_descendant_of_type_named<DisplaySettings::MonitorWidget>("monitor_widget");

2
Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp
View file

@ -23,7 +23,7 @@ DesktopSettingsWidget::DesktopSettingsWidget()
void DesktopSettingsWidget::create_frame()
{
load_from_gml(desktop_settings_gml);
try_load_from_gml(desktop_settings_gml).release_value_but_fixme_should_propagate_errors();
m_workspace_rows_spinbox = *find_descendant_of_type_named<GUI::SpinBox>("workspace_rows_spinbox");
m_workspace_rows_spinbox->on_change = [&](auto) {

2
Userland/Applications/DisplaySettings/EffectsSettingsWidget.cpp
View file

@ -18,7 +18,7 @@ namespace DisplaySettings {
EffectsSettingsWidget::EffectsSettingsWidget()
{
load_from_gml(effects_settings_gml);
try_load_from_gml(effects_settings_gml).release_value_but_fixme_should_propagate_errors();
m_geometry_combobox = find_descendant_of_type_named<ComboBox>("geometry_combobox");
m_geometry_combobox->set_only_allow_values_from_model(true);

2
Userland/Applications/DisplaySettings/FontSettingsWidget.cpp
View file

@ -19,7 +19,7 @@ static void update_label_with_font(GUI::Label&, Gfx::Font const&);
FontSettingsWidget::FontSettingsWidget()
{
load_from_gml(font_settings_gml);
try_load_from_gml(font_settings_gml).release_value_but_fixme_should_propagate_errors();
auto& default_font = Gfx::FontDatabase::default_font();
m_default_font_label = *find_descendant_of_type_named<GUI::Label>("default_font_label");

2
Userland/Applications/DisplaySettings/MonitorSettingsWidget.cpp
View file

@ -71,7 +71,7 @@ void MonitorSettingsWidget::create_resolution_list()
void MonitorSettingsWidget::create_frame()
{
load_from_gml(monitor_settings_window_gml);
try_load_from_gml(monitor_settings_window_gml).release_value_but_fixme_should_propagate_errors();
m_monitor_widget = *find_descendant_of_type_named<DisplaySettings::MonitorWidget>("monitor_widget");

2
Userland/Applications/DisplaySettings/ThemesSettingsWidget.cpp
View file

@ -21,7 +21,7 @@ namespace DisplaySettings {
ThemesSettingsWidget::ThemesSettingsWidget(bool& background_settings_changed)
: m_background_settings_changed { background_settings_changed }
{
load_from_gml(themes_settings_gml);
try_load_from_gml(themes_settings_gml).release_value_but_fixme_should_propagate_errors();
m_themes = MUST(Gfx::list_installed_system_themes());
size_t current_theme_index;