RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:17:34 +00:00
Code Issues Activity Actions

Userland: Replace all uses of load_from_gml with try_load_from_gml

Browse source 
MOAR FIXMES! ;^)
This commit is contained in:
Sam Atkins 2023-01-07 12:33:53 +00:00 • committed by Linus Groh
parent 703da34947
commit 54b1326165
78 changed files with 94 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/EmojiInputDialog.cpp
View file

@ -93,8 +93,7 @@ EmojiInputDialog::EmojiInputDialog(Window* parent_window)
, m_category_action_group(make<ActionGroup>())
{
auto main_widget = set_main_widget<Frame>().release_value_but_fixme_should_propagate_errors();
if (!main_widget->load_from_gml(emoji_input_dialog_gml))
VERIFY_NOT_REACHED();
main_widget->try_load_from_gml(emoji_input_dialog_gml).release_value_but_fixme_should_propagate_errors();
set_window_type(GUI::WindowType::Popup);
set_window_mode(GUI::WindowMode::Modeless);

3
Userland/Libraries/LibGUI/FilePicker.cpp
View file

@ -85,8 +85,7 @@ FilePicker::FilePicker(Window* parent_window, Mode mode, StringView filename, St
resize(560, 320);
auto widget = set_main_widget<GUI::Widget>().release_value_but_fixme_should_propagate_errors();
if (!widget->load_from_gml(file_picker_dialog_gml))
VERIFY_NOT_REACHED();
widget->try_load_from_gml(file_picker_dialog_gml).release_value_but_fixme_should_propagate_errors();
auto& toolbar = *widget->find_descendant_of_type_named<GUI::Toolbar>("toolbar");

3
Userland/Libraries/LibGUI/FontPicker.cpp
View file

@ -27,8 +27,7 @@ FontPicker::FontPicker(Window* parent_window, Gfx::Font const* current_font, boo
set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/16x16/app-font-editor.png"sv).release_value_but_fixme_should_propagate_errors());
auto widget = set_main_widget<GUI::Widget>().release_value_but_fixme_should_propagate_errors();
if (!widget->load_from_gml(font_picker_dialog_gml))
VERIFY_NOT_REACHED();
widget->try_load_from_gml(font_picker_dialog_gml).release_value_but_fixme_should_propagate_errors();
m_family_list_view = *widget->find_descendant_of_type_named<ListView>("family_list_view");
m_family_list_view->set_model(ItemListModel<DeprecatedString>::create(m_families));

2
Userland/Libraries/LibGUI/IncrementalSearchBanner.cpp
View file

@ -19,7 +19,7 @@ namespace GUI {
IncrementalSearchBanner::IncrementalSearchBanner(TextEditor& editor)
: m_editor(editor)
{
load_from_gml(incremental_search_banner_gml);
try_load_from_gml(incremental_search_banner_gml).release_value_but_fixme_should_propagate_errors();
m_index_label = find_descendant_of_type_named<Label>("incremental_search_banner_index_label");
m_wrap_search_button = find_descendant_of_type_named<Button>("incremental_search_banner_wrap_search_button");

3
Userland/Libraries/LibGUI/PasswordInputDialog.cpp
View file

@ -23,8 +23,7 @@ PasswordInputDialog::PasswordInputDialog(Window* parent_window, DeprecatedString
set_title(move(title));
auto widget = set_main_widget<Widget>().release_value_but_fixme_should_propagate_errors();
widget->load_from_gml(password_input_dialog_gml);
widget->try_load_from_gml(password_input_dialog_gml).release_value_but_fixme_should_propagate_errors();
auto& key_icon_label = *widget->find_descendant_of_type_named<GUI::Label>("key_icon_label");