RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:38:11 +00:00
Code Issues Activity Actions

AK: Pass correct length to StringUtils::convert_to_floating_point()

Browse source 
Fixed the issue in StringUtils::convert_to_floating_point() where the
end pointer of the trimmed string was not being passed, causing the
function to consistently return 'None' when given strings with trailing
whitespaces.
This commit is contained in:
hanaa12G 2023-10-14 15:42:59 +07:00 • committed by Tim Schumacher
parent f0be812fc2
commit 54e1470467
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
AK/StringUtils.cpp
View file

@ -247,7 +247,7 @@ Optional<T> convert_to_floating_point(StringView str, TrimWhitespace trim_whites
: str; : str;
char const* start = string.characters_without_null_termination(); char const* start = string.characters_without_null_termination();
return parse_floating_point_completely<T>(start, start + str.length()); return parse_floating_point_completely<T>(start, start + string.length());
} }
template Optional<double> convert_to_floating_point(StringView str, TrimWhitespace); template Optional<double> convert_to_floating_point(StringView str, TrimWhitespace);

7
Tests/AK/TestStringUtils.cpp
View file

@ -319,6 +319,13 @@ TEST_CASE(convert_to_uint_from_octal)
EXPECT_EQ(actual.value(), 0177777u); EXPECT_EQ(actual.value(), 0177777u);
} }
TEST_CASE(convert_to_floating_point)
{
auto number_string = " 123.45 "sv;
auto maybe_number = AK::StringUtils::convert_to_floating_point<float>(number_string, TrimWhitespace::Yes);
EXPECT_APPROXIMATE(maybe_number.value(), 123.45f);
}
TEST_CASE(ends_with) TEST_CASE(ends_with)
{ {
DeprecatedString test_string = "ABCDEF"; DeprecatedString test_string = "ABCDEF";