RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 04:37:35 +00:00
Code Issues Activity Actions

DevTools: Mark compilation-unit-only functions as static

Browse source 
This enables a nice warning in case a function becomes dead code. Also, in case
of signal_trampoline_dummy, marking it external (non-static) prevents it from
being 'optimized away', which would lead to surprising and weird linker errors.
This commit is contained in:
Ben Wiederhake 2020-08-10 23:45:11 +02:00 • committed by Andreas Kling
parent 84e112be6b
commit 5574d45eda
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
DevTools/Profiler/main.cpp
View file

@ -132,7 +132,7 @@ int main(int argc, char** argv)
return app->exec();
}
bool prompt_to_stop_profiling()
static bool prompt_to_stop_profiling()
{
auto window = GUI::Window::construct();
window->set_title("Profiling");