mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 07:17:35 +00:00
LibDSP: Fix potential slicing issue in volume_from_envelope
Use pointer or reference to avoid slicing from "PitchedEnvelope" to "Envelope". This was found by SonarCloud.
This commit is contained in:
parent
a225b26d88
commit
55aecf5381
3 changed files with 3 additions and 3 deletions
|
@ -50,7 +50,7 @@ struct Envelope {
|
|||
|
||||
constexpr void reset() { envelope = -1; }
|
||||
|
||||
constexpr operator EnvelopeState()
|
||||
constexpr operator EnvelopeState() const
|
||||
{
|
||||
if (!is_active())
|
||||
return EnvelopeState::Off;
|
||||
|
|
|
@ -64,7 +64,7 @@ Signal Classic::process_impl(Signal const& input_signal)
|
|||
}
|
||||
|
||||
// Linear ADSR envelope with no peak adjustment.
|
||||
double Classic::volume_from_envelope(Envelope envelope)
|
||||
double Classic::volume_from_envelope(Envelope const& envelope)
|
||||
{
|
||||
switch (static_cast<EnvelopeState>(envelope)) {
|
||||
case EnvelopeState::Off:
|
||||
|
|
|
@ -49,7 +49,7 @@ public:
|
|||
private:
|
||||
virtual Signal process_impl(Signal const&) override;
|
||||
|
||||
double volume_from_envelope(Envelope);
|
||||
double volume_from_envelope(Envelope const&);
|
||||
double wave_position(u8 note);
|
||||
double samples_per_cycle(u8 note);
|
||||
double sin_position(u8 note);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue