1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:07:36 +00:00

LibWeb: Move scroll offset state from layout tree to dom tree

Scroll offset state should not be reset by layout tree rebuilt.
This commit is contained in:
Aliaksandr Kalenik 2023-08-06 02:15:21 +02:00 committed by Andreas Kling
parent b6ea4b002b
commit 55b5c61a79
3 changed files with 36 additions and 5 deletions

View file

@ -61,12 +61,35 @@ bool Box::is_scrollable() const
return computed_values().overflow_y() == CSS::Overflow::Scroll;
}
CSSPixelPoint Box::scroll_offset() const
{
if (is_generated_for_before_pseudo_element())
return pseudo_element_generator()->scroll_offset(DOM::Element::ScrollOffsetFor::PseudoBefore);
if (is_generated_for_after_pseudo_element())
return pseudo_element_generator()->scroll_offset(DOM::Element::ScrollOffsetFor::PseudoAfter);
if (!is<DOM::Element>(*dom_node()))
return {};
return static_cast<DOM::Element const*>(dom_node())->scroll_offset(DOM::Element::ScrollOffsetFor::Self);
}
void Box::set_scroll_offset(CSSPixelPoint offset)
{
// FIXME: If there is horizontal and vertical scroll ignore only part of the new offset
if (offset.y() < 0 || m_scroll_offset == offset)
if (offset.y() < 0 || scroll_offset() == offset)
return;
m_scroll_offset = offset;
if (is_generated_for_before_pseudo_element()) {
pseudo_element_generator()->set_scroll_offset(DOM::Element::ScrollOffsetFor::PseudoBefore, offset);
} else if (is_generated_for_after_pseudo_element()) {
pseudo_element_generator()->set_scroll_offset(DOM::Element::ScrollOffsetFor::PseudoAfter, offset);
} else if (is<DOM::Element>(*dom_node())) {
static_cast<DOM::Element*>(dom_node())->set_scroll_offset(DOM::Element::ScrollOffsetFor::Self, offset);
} else {
return;
}
set_needs_display();
}