From 55c099c953ad7f3d8b4292fb223b4b4f1bd46159 Mon Sep 17 00:00:00 2001 From: Enver Balalic Date: Mon, 26 Sep 2022 20:09:38 +0200 Subject: [PATCH] LibHTTP: Null out on_ready_to_read on socket close This fixes the segfault reported in #15283. on_ready_to_read gets re-registered on every job start anyways. I see no reason why this could be bad. --- Userland/Libraries/LibHTTP/Job.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Userland/Libraries/LibHTTP/Job.cpp b/Userland/Libraries/LibHTTP/Job.cpp index f9f3e99453..08cc10b542 100644 --- a/Userland/Libraries/LibHTTP/Job.cpp +++ b/Userland/Libraries/LibHTTP/Job.cpp @@ -127,6 +127,7 @@ void Job::shutdown(ShutdownMode mode) return; if (mode == ShutdownMode::CloseSocket) { m_socket->close(); + m_socket->on_ready_to_read = nullptr; } else { m_socket->on_ready_to_read = nullptr; m_socket = nullptr;