RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

LibHTTP: Ensure finish_up() is not called more than once

Browse source 
There's no reason to manually call it on TLS close, the HTTP reading
logic is smart enough to handle connection closes transparently.
Fixes #8211.
This commit is contained in:
Ali Mohammad Pur 2021-06-28 16:12:04 +04:30 • committed by Andreas Kling
parent 2a7cb4fe42
commit 55fa2329de
2 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibHTTP/HttpsJob.cpp
View file

@ -38,9 +38,6 @@ void HttpsJob::start()
}); });
} }
}; };
m_socket->on_tls_finished = [&] {
finish_up();
};
m_socket->on_tls_certificate_request = [this](auto&) { m_socket->on_tls_certificate_request = [this](auto&) {
if (on_certificate_requested) if (on_certificate_requested)
on_certificate_requested(*this); on_certificate_requested(*this);

1
Userland/Libraries/LibHTTP/Job.cpp
View file

@ -360,6 +360,7 @@ void Job::timer_event(Core::TimerEvent& event)
void Job::finish_up() void Job::finish_up()
{ {
VERIFY(m_state != State::Finished);
m_state = State::Finished; m_state = State::Finished;
if (!m_can_stream_response) { if (!m_can_stream_response) {
auto flattened_buffer = ByteBuffer::create_uninitialized(m_received_size); auto flattened_buffer = ByteBuffer::create_uninitialized(m_received_size);