RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

LibWeb: Do not assume field element is always a HTMLInputElement

Browse source 
Cast to a HTMLElement instead and retrieve the value attribute from
there instead.
This commit is contained in:
Kenneth Myhra 2023-02-13 10:59:19 +01:00 • committed by Linus Groh
parent 7d23af49c2
commit 562594c416
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/FormControlInfrastructure.cpp
View file

@ -150,9 +150,9 @@ WebIDL::ExceptionOr<Optional<HashMapWithVectorOfFormDataEntryValue>> construct_e
// FIXME: 2. Create an entry with name and charset, and append it to entry list.
// 10. Otherwise, create an entry with name and the value of the field element, and append it to entry list.
else {
auto* input_element = dynamic_cast<HTML::HTMLInputElement*>(control.ptr());
VERIFY(input_element);
TRY_OR_THROW_OOM(vm, form_data_entries.try_append(input_element->value()));
auto* element = dynamic_cast<HTML::HTMLElement*>(control.ptr());
VERIFY(element);
TRY_OR_THROW_OOM(vm, form_data_entries.try_append(element->attribute("value"sv)));
TRY_OR_THROW_OOM(vm, entry_list.try_set(name, form_data_entries));
}