diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index 1fe096f6f0..7d6b85e201 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -1427,7 +1427,7 @@ WebIDL::ExceptionOr> Document::create_pr // FIXME: 2. If data contains the string "?>", then throw an "InvalidCharacterError" DOMException. // 3. Return a new ProcessingInstruction node, with target set to target, data set to data, and node document set to this. - return heap().allocate(realm(), *this, data.to_byte_string(), target.to_byte_string()); + return heap().allocate(realm(), *this, data, target); } JS::NonnullGCPtr Document::create_range() diff --git a/Userland/Libraries/LibWeb/DOM/Node.cpp b/Userland/Libraries/LibWeb/DOM/Node.cpp index 57f26e3120..f935ab6148 100644 --- a/Userland/Libraries/LibWeb/DOM/Node.cpp +++ b/Userland/Libraries/LibWeb/DOM/Node.cpp @@ -872,7 +872,7 @@ JS::NonnullGCPtr Node::clone_node(Document* document, bool clone_children) auto processing_instruction = verify_cast(this); // Set copy’s target and data to those of node. - auto processing_instruction_copy = heap().allocate(realm(), *document, processing_instruction->data().to_byte_string(), processing_instruction->target()); + auto processing_instruction_copy = heap().allocate(realm(), *document, processing_instruction->data(), processing_instruction->target()); copy = processing_instruction_copy; } // Otherwise, Do nothing. diff --git a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp index 82512f64ab..64da6f8907 100644 --- a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp +++ b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.cpp @@ -13,8 +13,8 @@ namespace Web::DOM { JS_DEFINE_ALLOCATOR(ProcessingInstruction); -ProcessingInstruction::ProcessingInstruction(Document& document, ByteString const& data, ByteString const& target) - : CharacterData(document, NodeType::PROCESSING_INSTRUCTION_NODE, MUST(String::from_byte_string(data))) +ProcessingInstruction::ProcessingInstruction(Document& document, String const& data, String const& target) + : CharacterData(document, NodeType::PROCESSING_INSTRUCTION_NODE, data) , m_target(target) { } diff --git a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h index ba2dfe6103..9677956e9e 100644 --- a/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h +++ b/Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h @@ -17,16 +17,16 @@ class ProcessingInstruction final : public CharacterData { public: virtual ~ProcessingInstruction() override = default; - virtual FlyString node_name() const override { return MUST(FlyString::from_deprecated_fly_string(m_target)); } + virtual FlyString node_name() const override { return m_target; } - ByteString const& target() const { return m_target; } + String const& target() const { return m_target; } private: - ProcessingInstruction(Document&, ByteString const& data, ByteString const& target); + ProcessingInstruction(Document&, String const& data, String const& target); virtual void initialize(JS::Realm&) override; - ByteString m_target; + String m_target; }; template<>