RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

LibJS: Use the GetPrototypeFromConstructor AO for TypedArrays creation

Browse source
This commit is contained in:
Idan Horowitz 2021-07-05 02:40:15 +03:00 • committed by Linus Groh
parent 9cae827f07
commit 56335dab6c
2 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibJS/Runtime/TypedArray.cpp
View file

@ -197,6 +197,15 @@ void TypedArrayBase::visit_edges(Visitor& visitor)
} }
#define JS_DEFINE_TYPED_ARRAY(ClassName, snake_name, PrototypeName, ConstructorName, Type) \ #define JS_DEFINE_TYPED_ARRAY(ClassName, snake_name, PrototypeName, ConstructorName, Type) \
ClassName* ClassName::create(GlobalObject& global_object, u32 length, FunctionObject& new_target) \
{ \
auto& vm = global_object.vm(); \
auto* prototype = get_prototype_from_constructor(global_object, new_target, &GlobalObject::snake_name##_prototype); \
if (vm.exception()) \
return {}; \
return global_object.heap().allocate<ClassName>(global_object, length, *prototype); \
} \
\
ClassName* ClassName::create(GlobalObject& global_object, u32 length) \ ClassName* ClassName::create(GlobalObject& global_object, u32 length) \
{ \ { \
return global_object.heap().allocate<ClassName>(global_object, length, *global_object.snake_name##_prototype()); \ return global_object.heap().allocate<ClassName>(global_object, length, *global_object.snake_name##_prototype()); \
@ -257,15 +266,17 @@ void TypedArrayBase::visit_edges(Visitor& visitor)
} \ } \
\ \
/* 23.2.5.1 TypedArray ( ...args ), https://tc39.es/ecma262/#sec-typedarray */ \ /* 23.2.5.1 TypedArray ( ...args ), https://tc39.es/ecma262/#sec-typedarray */ \
Value ConstructorName::construct(FunctionObject&) \ Value ConstructorName::construct(FunctionObject& new_target) \
{ \ { \
auto& vm = this->vm(); \ auto& vm = this->vm(); \
if (vm.argument_count() == 0) \ if (vm.argument_count() == 0) \
return ClassName::create(global_object(), 0); \ return ClassName::create(global_object(), 0, new_target); \
\ \
auto first_argument = vm.argument(0); \ auto first_argument = vm.argument(0); \
if (first_argument.is_object()) { \ if (first_argument.is_object()) { \
auto* typed_array = ClassName::create(global_object(), 0); \ auto* typed_array = ClassName::create(global_object(), 0, new_target); \
if (vm.exception()) \
return {}; \
if (first_argument.as_object().is_typed_array()) { \ if (first_argument.as_object().is_typed_array()) { \
auto& arg_typed_array = static_cast<TypedArrayBase&>(first_argument.as_object()); \ auto& arg_typed_array = static_cast<TypedArrayBase&>(first_argument.as_object()); \
initialize_typed_array_from_typed_array(global_object(), *typed_array, arg_typed_array); \ initialize_typed_array_from_typed_array(global_object(), *typed_array, arg_typed_array); \
@ -310,7 +321,7 @@ void TypedArrayBase::visit_edges(Visitor& visitor)
vm.throw_exception<RangeError>(global_object(), ErrorType::InvalidLength, "typed array"); \ vm.throw_exception<RangeError>(global_object(), ErrorType::InvalidLength, "typed array"); \
return {}; \ return {}; \
} \ } \
return ClassName::create(global_object(), array_length); \ return ClassName::create(global_object(), array_length, new_target); \
} }
#undef __JS_ENUMERATE #undef __JS_ENUMERATE

1
Userland/Libraries/LibJS/Runtime/TypedArray.h
View file

@ -494,6 +494,7 @@ private:
\ \
public: \ public: \
virtual ~ClassName(); \ virtual ~ClassName(); \
static ClassName* create(GlobalObject&, u32 length, FunctionObject& new_target); \
static ClassName* create(GlobalObject&, u32 length); \ static ClassName* create(GlobalObject&, u32 length); \
ClassName(u32 length, Object& prototype); \ ClassName(u32 length, Object& prototype); \
virtual String element_name() const override; \ virtual String element_name() const override; \