RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

AK+LibWeb: Do not percent encode/decode in URL fragment setter/getters

Browse source 
The web specs do not expect decoding or decoding to happen when calling
these helpers. This allows us to remove the raw_fragment helper function
from the URL class.
This commit is contained in:
Shannon Booth 2023-08-12 19:34:25 +12:00 • committed by Andrew Kaster
parent c25485700a
commit 5663a2d3b4
3 changed files with 3 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1737,7 +1737,7 @@ Document::IndicatedPart Document::determine_the_indicated_part() const
// For an HTML document document, the following processing model must be followed to determine its indicated part:
// 1. Let fragment be document's URL's fragment.
auto fragment = url().raw_fragment();
auto fragment = url().fragment();
// 2. If fragment is the empty string, then return the special value top of the document.
if (fragment.is_empty())
@ -1752,8 +1752,7 @@ Document::IndicatedPart Document::determine_the_indicated_part() const
// 5. Let fragmentBytes be the result of percent-decoding fragment.
// 6. Let decodedFragment be the result of running UTF-8 decode without BOM on fragmentBytes.
// NOTE: 5 and 6 are done as a single step in `AK::URL::fragment()`.
auto decoded_fragment = url().fragment();
auto decoded_fragment = AK::URL::percent_decode(fragment);
// 7. Set potentialIndicatedElement to the result of finding a potential indicated element given document and decodedFragment.
potential_indicated_element = find_a_potential_indicated_element(decoded_fragment);