RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:47:34 +00:00
Code Issues Activity Actions

Kernel+LibELF+LibCoreDump+CrashReporter: Use JSON for ProcessInfo

Browse source 
This is in preparation of adding (much) more process information to
coredumps. As we can only have one null-terminated char[] of arbitrary
length in each struct it's now a single JSON blob, which is a great fit:
easily extensible in the future and allows for key/value pairs and even
nested objects, which will be used e.g. for the process environment, for
example.
This commit is contained in:
Linus Groh 2021-01-13 23:59:22 +01:00 • committed by Andreas Kling
parent 7ad9b116f7
commit 568cde5e23
5 changed files with 72 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibELF/CoreDump.h
View file

@ -50,9 +50,14 @@ struct [[gnu::packed]] NotesEntry {
struct [[gnu::packed]] ProcessInfo {
NotesEntryHeader header;
int pid;
u8 termination_signal;
char executable_path[]; // Null terminated
// Information is stored as JSON blob to allow arbitrary
// number and length of strings/objects/arrays.
//
// Keys:
// - "pid" (int)
// - "termination_signal" (u8)
// - "executable_path" (String)
char json_data[]; // Null terminated
};
struct [[gnu::packed]] ThreadInfo {
@ -81,6 +86,11 @@ struct [[gnu::packed]] MemoryRegionInfo {
struct [[gnu::packed]] Metadata {
NotesEntryHeader header;
// Arbitrary metadata, set via SC_set_coredump_metadata.
// Limited to 16 entries and 16 KiB keys/values by the kernel.
//
// Well-known keys:
// - "assertion": Used by LibC's __assertion_failed() to store assertion info
char json_data[]; // Null terminated
};