RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:57:35 +00:00
Code Issues Activity Actions

LibJS: Adjust order of operations in ISO{Date,MonthDay}FromFields

Browse source 
This is a normative change in the Temporal spec.

See: 7dd90dc
This commit is contained in:
Linus Groh 2022-06-15 00:45:31 +01:00
parent 3bc54ac75a
commit 569c2dc1d0
8 changed files with 32 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Tests/builtins/Temporal/Calendar/Calendar.prototype.era.js
View file

@ -21,6 +21,6 @@ describe("errors", () => {
const calendar = new Temporal.Calendar("iso8601");
expect(() => {
calendar.era({});
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
});
});

2
Userland/Libraries/LibJS/Tests/builtins/Temporal/Calendar/Calendar.prototype.eraYear.js
View file

@ -21,6 +21,6 @@ describe("errors", () => {
const calendar = new Temporal.Calendar("iso8601");
expect(() => {
calendar.eraYear({});
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
});
});

2
Userland/Libraries/LibJS/Tests/builtins/Temporal/Calendar/Calendar.prototype.monthDayFromFields.js
View file

@ -37,7 +37,7 @@ describe("errors", () => {
test("month or monthCode field is required", () => {
const calendar = new Temporal.Calendar("iso8601");
expect(() => {
calendar.monthDayFromFields({ year: 2021 });
calendar.monthDayFromFields({ year: 2021, day: 1 });
}).toThrowWithMessage(TypeError, "Required property month is missing or undefined");
});

8
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.from.js
View file

@ -113,13 +113,13 @@ describe("errors", () => {
test("missing fields", () => {
expect(() => {
Temporal.PlainDateTime.from({});
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
expect(() => {
Temporal.PlainDateTime.from({ year: 0 });
Temporal.PlainDateTime.from({ year: 0, day: 1 });
}).toThrowWithMessage(TypeError, "Required property month is missing or undefined");
expect(() => {
Temporal.PlainDateTime.from({ year: 0, month: 1 });
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
Temporal.PlainDateTime.from({ month: 1, day: 1 });
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
});
test("with 'reject' overflow option", () => {

2
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainMonthDay/PlainMonthDay.from.js
View file

@ -52,7 +52,7 @@ describe("errors", () => {
test("missing fields", () => {
expect(() => {
Temporal.PlainMonthDay.from({});
}).toThrowWithMessage(TypeError, "Required property month is missing or undefined");
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
expect(() => {
Temporal.PlainMonthDay.from({ month: 1 });
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");

8
Userland/Libraries/LibJS/Tests/builtins/Temporal/ZonedDateTime/ZonedDateTime.from.js
View file

@ -129,12 +129,16 @@ describe("errors", () => {
test("requires year property", () => {
expect(() => {
Temporal.ZonedDateTime.from({ timeZone: new Temporal.TimeZone("UTC") });
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
});
test("requires month property", () => {
expect(() => {
Temporal.ZonedDateTime.from({ timeZone: new Temporal.TimeZone("UTC"), year: 2021 });
Temporal.ZonedDateTime.from({
timeZone: new Temporal.TimeZone("UTC"),
day: 1,
year: 2021,
});
}).toThrowWithMessage(TypeError, "Required property month is missing or undefined");
});

8
Userland/Libraries/LibJS/Tests/builtins/Temporal/ZonedDateTime/ZonedDateTime.prototype.withPlainDate.js
View file

@ -70,14 +70,14 @@ describe("errors", () => {
test("missing properties", () => {
expect(() => {
new Temporal.ZonedDateTime(1n, {}).withPlainDate({});
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
expect(() => {
new Temporal.ZonedDateTime(1n, {}).withPlainDate({ year: 1 });
new Temporal.ZonedDateTime(1n, {}).withPlainDate({ day: 1, year: 1 });
}).toThrowWithMessage(TypeError, "Required property month is missing or undefined");
expect(() => {
new Temporal.ZonedDateTime(1n, {}).withPlainDate({ year: 1, month: 1 });
}).toThrowWithMessage(TypeError, "Required property day is missing or undefined");
new Temporal.ZonedDateTime(1n, {}).withPlainDate({ day: 1, month: 1 });
}).toThrowWithMessage(TypeError, "Required property year is missing or undefined");
});
});