RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:47:45 +00:00
Code Issues Activity Actions

LibJS: Add missing spec step to CompareTypedArrayElements

Browse source 
This isn't actually much of an issue because if the LHS side value is -0
and the RHS value is +0, errantly returning 0 in the comparison function
here has the same effect as correctly returning -1. In both cases, the
-0 is left on the LHS.
This commit is contained in:
Timothy Flynn 2022-07-25 09:52:06 -04:00 • committed by Linus Groh
parent 864221cb02
commit 56db4235df
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/TypedArray.cpp
View file

@ -412,6 +412,10 @@ ThrowCompletionOr<double> compare_typed_array_elements(GlobalObject& global_obje
: (x.as_double() > y.as_double())) : (x.as_double() > y.as_double()))
return 1; return 1;
// 8. If x is -0𝔽 and y is +0𝔽, return -1𝔽.
if (x.is_negative_zero() && y.is_positive_zero())
return -1;
// 9. If x is +0𝔽 and y is -0𝔽, return 1𝔽. // 9. If x is +0𝔽 and y is -0𝔽, return 1𝔽.
if (x.is_positive_zero() && y.is_negative_zero()) if (x.is_positive_zero() && y.is_negative_zero())
return 1; return 1;