RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 20:25:07 +00:00
Code Issues Activity Actions

LibWeb: Correct invalid index check in HTMLTableElement::insertRow()

Browse source 
As well as change the matching error message in deleteRow(), which
likely caused this mistake in the first place.
This commit is contained in:
Idan Horowitz 2022-03-12 23:48:05 +02:00 • committed by Andreas Kling
parent fe3b846ac8
commit 57090f75ae
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLTableElement.cpp
View file

@ -284,7 +284,7 @@ DOM::ExceptionOr<NonnullRefPtr<HTMLTableRowElement>> HTMLTableElement::insert_ro
auto rows = this->rows();
auto rows_length = rows->length();
if (index < -1 || index >= (long)rows_length) {
if (index < -1 || index > (long)rows_length) {
return DOM::IndexSizeError::create("Index is negative or greater than the number of rows");
}
auto tr = static_ptr_cast<HTMLTableRowElement>(DOM::create_element(document(), TagNames::tr, Namespace::HTML));
@ -312,7 +312,7 @@ DOM::ExceptionOr<void> HTMLTableElement::delete_row(long index)
// 1. If index is less than −1 or greater than or equal to the number of elements in the rows collection, then throw an "IndexSizeError" DOMException.
if (index < -1 || index >= (long)rows_length)
return DOM::IndexSizeError::create("Index is negative or greater than the number of rows");
return DOM::IndexSizeError::create("Index is negative or greater than or equal to the number of rows");
// 2. If index is −1, then remove the last element in the rows collection from its parent, or do nothing if the rows collection is empty.
if (index == -1) {