From 57142a29a0a2062e96f9cddd5fe0f01857bb50eb Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 9 Mar 2021 13:57:17 +0100 Subject: [PATCH] UserspaceEmulator: Don't set the MmapRegion malloc-block bit too early We were setting it before the malloc metadata had been instantiated. Fixes #5707. --- Userland/DevTools/UserspaceEmulator/MallocTracer.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/Userland/DevTools/UserspaceEmulator/MallocTracer.cpp b/Userland/DevTools/UserspaceEmulator/MallocTracer.cpp index c98421f6b0..111dc9c55d 100644 --- a/Userland/DevTools/UserspaceEmulator/MallocTracer.cpp +++ b/Userland/DevTools/UserspaceEmulator/MallocTracer.cpp @@ -64,9 +64,6 @@ void MallocTracer::target_did_malloc(Badge, FlatPtr address, size_t si VERIFY(is(*region)); auto& mmap_region = static_cast(*region); - // Mark the containing mmap region as a malloc block! - mmap_region.set_malloc(true); - auto* shadow_bits = mmap_region.shadow_data() + address - mmap_region.base(); memset(shadow_bits, 0, size);