RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:37:46 +00:00
Code Issues Activity Actions

LibJS: Rename IsValidTimeZoneName to IsAvailableTimeZoneName

Browse source 
This is an editorial change in the Temporal spec.

See: 873313b
This commit is contained in:
Linus Groh 2022-10-17 09:11:32 +02:00
parent 72997c6b77
commit 57162ad510
6 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Intl/DateTimeFormatConstructor.cpp
View file

@ -224,8 +224,8 @@ ThrowCompletionOr<DateTimeFormat*> initialize_date_time_format(VM& vm, DateTimeF
// a. Set timeZone to ? ToString(timeZone). // a. Set timeZone to ? ToString(timeZone).
time_zone = TRY(time_zone_value.to_string(vm)); time_zone = TRY(time_zone_value.to_string(vm));
// b. If the result of IsValidTimeZoneName(timeZone) is false, then // b. If IsAvailableTimeZoneName(timeZone) is false, then
if (!Temporal::is_valid_time_zone_name(time_zone)) { if (!Temporal::is_available_time_zone_name(time_zone)) {
// i. Throw a RangeError exception. // i. Throw a RangeError exception.
return vm.throw_completion<RangeError>(ErrorType::OptionIsNotValidValue, time_zone, vm.names.timeZone); return vm.throw_completion<RangeError>(ErrorType::OptionIsNotValidValue, time_zone, vm.names.timeZone);
} }

4
Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp
View file

@ -631,8 +631,8 @@ ThrowCompletionOr<Value> to_relative_temporal_object(VM& vm, Object const& optio
else { else {
// i. If IsTimeZoneOffsetString(timeZoneName) is false, then // i. If IsTimeZoneOffsetString(timeZoneName) is false, then
if (!is_time_zone_offset_string(*time_zone_name)) { if (!is_time_zone_offset_string(*time_zone_name)) {
// 1. If IsValidTimeZoneName(timeZoneName) is false, throw a RangeError exception. // 1. If IsAvailableTimeZoneName(timeZoneName) is false, throw a RangeError exception.
if (!is_valid_time_zone_name(*time_zone_name)) if (!is_available_time_zone_name(*time_zone_name))
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, *time_zone_name); return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, *time_zone_name);
// 2. Set timeZoneName to ! CanonicalizeTimeZoneName(timeZoneName). // 2. Set timeZoneName to ! CanonicalizeTimeZoneName(timeZoneName).

8
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp
View file

@ -27,8 +27,8 @@ TimeZone::TimeZone(Object& prototype)
{ {
} }
// 11.1.1 IsValidTimeZoneName ( timeZone ), https://tc39.es/proposal-temporal/#sec-isvalidtimezonename // 11.1.1 IsAvailableTimeZoneName ( timeZone ), https://tc39.es/proposal-temporal/#sec-isavailabletimezonename
bool is_valid_time_zone_name(StringView time_zone) bool is_available_time_zone_name(StringView time_zone)
{ {
// 1. Let timeZones be AvailableTimeZones(). // 1. Let timeZones be AvailableTimeZones().
// 2. For each String candidate in timeZones, do // 2. For each String candidate in timeZones, do
@ -331,8 +331,8 @@ ThrowCompletionOr<Object*> to_temporal_time_zone(VM& vm, Value temporal_time_zon
// b. If IsTimeZoneOffsetString(name) is false, then // b. If IsTimeZoneOffsetString(name) is false, then
if (!is_time_zone_offset_string(name)) { if (!is_time_zone_offset_string(name)) {
// i. If IsValidTimeZoneName(name) is false, throw a RangeError exception. // i. If IsAvailableTimeZoneName(name) is false, throw a RangeError exception.
if (!is_valid_time_zone_name(name)) if (!is_available_time_zone_name(name))
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, name); return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, name);
// ii. Set name to ! CanonicalizeTimeZoneName(name). // ii. Set name to ! CanonicalizeTimeZoneName(name).

2
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h
View file

@ -36,7 +36,7 @@ private:
Optional<OffsetType> m_offset_nanoseconds; // [[OffsetNanoseconds]] Optional<OffsetType> m_offset_nanoseconds; // [[OffsetNanoseconds]]
}; };
bool is_valid_time_zone_name(StringView time_zone); bool is_available_time_zone_name(StringView time_zone);
String canonicalize_time_zone_name(String const& time_zone); String canonicalize_time_zone_name(String const& time_zone);
ThrowCompletionOr<TimeZone*> create_temporal_time_zone(VM&, String const& identifier, FunctionObject const* new_target = nullptr); ThrowCompletionOr<TimeZone*> create_temporal_time_zone(VM&, String const& identifier, FunctionObject const* new_target = nullptr);
ISODateTime get_iso_parts_from_epoch(VM&, Crypto::SignedBigInteger const& epoch_nanoseconds); ISODateTime get_iso_parts_from_epoch(VM&, Crypto::SignedBigInteger const& epoch_nanoseconds);

4
Userland/Libraries/LibJS/Runtime/Temporal/TimeZoneConstructor.cpp
View file

@ -52,8 +52,8 @@ ThrowCompletionOr<Object*> TimeZoneConstructor::construct(FunctionObject& new_ta
// 3. If IsTimeZoneOffsetString(identifier) is false, then // 3. If IsTimeZoneOffsetString(identifier) is false, then
if (!is_time_zone_offset_string(identifier)) { if (!is_time_zone_offset_string(identifier)) {
// a. If IsValidTimeZoneName(identifier) is false, then // a. If IsAvailableTimeZoneName(identifier) is false, then
if (!is_valid_time_zone_name(identifier)) { if (!is_available_time_zone_name(identifier)) {
// i. Throw a RangeError exception. // i. Throw a RangeError exception.
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, identifier); return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, identifier);
} }

4
Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTime.cpp
View file

@ -199,8 +199,8 @@ ThrowCompletionOr<ZonedDateTime*> to_temporal_zoned_date_time(VM& vm, Value item
// f. If IsTimeZoneOffsetString(timeZoneName) is false, then // f. If IsTimeZoneOffsetString(timeZoneName) is false, then
if (!is_time_zone_offset_string(*time_zone_name)) { if (!is_time_zone_offset_string(*time_zone_name)) {
// i. If IsValidTimeZoneName(timeZoneName) is false, throw a RangeError exception. // i. If IsAvailableTimeZoneName(timeZoneName) is false, throw a RangeError exception.
if (!is_valid_time_zone_name(*time_zone_name)) if (!is_available_time_zone_name(*time_zone_name))
return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, *time_zone_name); return vm.throw_completion<RangeError>(ErrorType::TemporalInvalidTimeZoneName, *time_zone_name);
// ii. Set timeZoneName to ! CanonicalizeTimeZoneName(timeZoneName). // ii. Set timeZoneName to ! CanonicalizeTimeZoneName(timeZoneName).