RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:32:44 +00:00
Code Issues Activity Actions

LibWeb: Add HTML elements to factories, add missing tags and attributes

Browse source 
This is mostly to get the grunt work of the way. This is split up into
multiple commits to hopefully make it more manageable to review.

Note that these are not full implementations, and the bindings mostly
get the low hanging fruit.

Also implements some attributes that I kept out because they had
dashes in them. Therefore, this closes #2905.
This commit is contained in:
Luke 2020-08-09 17:10:41 +01:00 • committed by Andreas Kling
parent be5a62d5d7
commit 5724ac8e72
13 changed files with 656 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View file

@ -51,15 +51,19 @@ static String snake_name(const StringView& title_name)
return builder.to_string();
}
static String add_underscore_to_cpp_keywords(const String& input)
static String make_input_acceptable_cpp(const String& input)
{
if (input == "class" || input == "template") {
if (input == "class" || input == "template" || input == "for") {
StringBuilder builder;
builder.append(input);
builder.append('_');
return builder.to_string();
}
return input;
String input_without_dashes = input;
input_without_dashes.replace("-", "_");
return input_without_dashes;
}
namespace IDL {
@ -638,7 +642,7 @@ void generate_implementation(const IDL::Interface& interface)
auto attribute_name = attribute.extended_attributes.get("Reflect").value();
if (attribute_name.is_null())
attribute_name = attribute.name;
attribute_name = add_underscore_to_cpp_keywords(attribute_name);
attribute_name = make_input_acceptable_cpp(attribute_name);
out() << " auto retval = impl->attribute(HTML::AttributeNames::" << attribute_name << ");";
} else {
out() << " auto retval = impl->" << snake_name(attribute.name) << "();";
@ -660,7 +664,7 @@ void generate_implementation(const IDL::Interface& interface)
auto attribute_name = attribute.extended_attributes.get("Reflect").value();
if (attribute_name.is_null())
attribute_name = attribute.name;
attribute_name = add_underscore_to_cpp_keywords(attribute_name);
attribute_name = make_input_acceptable_cpp(attribute_name);
out() << " impl->set_attribute(HTML::AttributeNames::" << attribute_name << ", cpp_value);";
} else {
out() << " impl->set_" << snake_name(attribute.name) << "(cpp_value);";