mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 20:17:44 +00:00
Kernel: static vs non-static constexpr variables
Problem: - `static` variables consume memory and sometimes are less optimizable. - `static const` variables can be `constexpr`, usually. - `static` function-local variables require an initialization check every time the function is run. Solution: - If a global `static` variable is only used in a single function then move it into the function and make it non-`static` and `constexpr`. - Make all global `static` variables `constexpr` instead of `const`. - Change function-local `static const[expr]` variables to be just `constexpr`.
This commit is contained in:
parent
2b64d163cd
commit
5751327195
15 changed files with 30 additions and 37 deletions
|
@ -127,7 +127,7 @@ void __ubsan_handle_out_of_bounds(const OutOfBoundsData& data, ValueHandle)
|
|||
void __ubsan_handle_type_mismatch_v1(const TypeMismatchData&, ValueHandle) __attribute__((used));
|
||||
void __ubsan_handle_type_mismatch_v1(const TypeMismatchData& data, ValueHandle ptr)
|
||||
{
|
||||
static const char* kinds[] = {
|
||||
constexpr StringView kinds[] = {
|
||||
"load of",
|
||||
"store to",
|
||||
"reference binding to",
|
||||
|
@ -143,7 +143,7 @@ void __ubsan_handle_type_mismatch_v1(const TypeMismatchData& data, ValueHandle p
|
|||
};
|
||||
|
||||
FlatPtr alignment = (FlatPtr)1 << data.log_alignment;
|
||||
auto* kind = kinds[data.type_check_kind];
|
||||
auto kind = kinds[data.type_check_kind];
|
||||
|
||||
if (!ptr) {
|
||||
dbgln("KUBSAN: {} null pointer of type {}", kind, data.type.name());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue