RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:47:47 +00:00
Code Issues Activity Actions

LibJS: Return false for NaN numbers in Value::to_boolean()

Browse source
This commit is contained in:
Jack Karamanian 2020-04-06 22:48:47 -05:00 • committed by Andreas Kling
parent 4a9485f830
commit 57bd194e5a
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/Value.cpp
View file

@ -83,6 +83,9 @@ bool Value::to_boolean() const
case Type::Boolean: case Type::Boolean:
return m_value.as_bool; return m_value.as_bool;
case Type::Number: case Type::Number:
if (is_nan()) {
return false;
}
return !(m_value.as_double == 0 || m_value.as_double == -0); return !(m_value.as_double == 0 || m_value.as_double == -0);
case Type::Null: case Type::Null:
case Type::Undefined: case Type::Undefined:

3
Libraries/LibJS/Tests/NaN-basic.js
View file

@ -10,6 +10,9 @@ try {
assert(isNaN(undefined) === true); assert(isNaN(undefined) === true);
assert(isNaN(null) === false); assert(isNaN(null) === false);
assert(isNaN(Infinity) === false); assert(isNaN(Infinity) === false);
assert(!!NaN === false);
assert(!!nan === false);
console.log("PASS"); console.log("PASS");
} catch (e) { } catch (e) {
console.log("FAIL: " + e); console.log("FAIL: " + e);