RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibLine: Ignore empty spans when stylizing

Browse source 
Previously we would erroneously apply the stylization to the whoever
called stylize next. Now we first check whether the span is non-empty
before stylizing. All non-empty spans must have at least one character
in them (end-exclusive).
This commit is contained in:
sin-ack 2022-07-16 23:37:03 +00:00 • committed by Ali Mohammad Pur
parent ac36d272d3
commit 57c8677b5c
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibLine/Editor.cpp
View file

@ -463,6 +463,8 @@ Editor::CodepointRange Editor::byte_offset_range_to_code_point_offset_range(size
void Editor::stylize(Span const& span, Style const& style) void Editor::stylize(Span const& span, Style const& style)
{ {
if (!span.is_empty())
return;
if (style.is_empty()) if (style.is_empty())
return; return;

5
Userland/Libraries/LibLine/Span.h
View file

@ -28,6 +28,11 @@ public:
size_t end() const { return m_end; } size_t end() const { return m_end; }
Mode mode() const { return m_mode; } Mode mode() const { return m_mode; }
bool is_empty() const
{
return m_beginning < m_end;
}
private: private:
size_t m_beginning { 0 }; size_t m_beginning { 0 };
size_t m_end { 0 }; size_t m_end { 0 };