RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 14:37:45 +00:00
Code Issues Activity Actions

Everywhere: Rename to_{string => deprecated_string}() where applicable

Browse source 
This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.
This commit is contained in:
Linus Groh 2022-12-06 01:12:49 +00:00 • committed by Andreas Kling
parent 6e19ab2bbc
commit 57dc179b1f
597 changed files with 1973 additions and 1972 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applets/ClipboardHistory/ClipboardHistoryModel.cpp
View file

@ -81,7 +81,7 @@ GUI::Variant ClipboardHistoryModel::data(const GUI::ModelIndex& index, GUI::Mode
builder.append(bpp_for_format_resilient(data_and_type.metadata.get("format").value_or("0")));
builder.append(']');
builder.append(" bitmap"sv);
return builder.to_string();
return builder.to_deprecated_string();
}
if (data_and_type.mime_type.starts_with("glyph/"sv)) {
StringBuilder builder;
@ -96,7 +96,7 @@ GUI::Variant ClipboardHistoryModel::data(const GUI::ModelIndex& index, GUI::Mode
builder.append_code_point(start);
builder.appendff(") [{}x{}]", width, height);
}
return builder.to_string();
return builder.to_deprecated_string();
}
return "<...>";
case Column::Type:
@ -104,7 +104,7 @@ GUI::Variant ClipboardHistoryModel::data(const GUI::ModelIndex& index, GUI::Mode
case Column::Size:
return AK::human_readable_size(data_and_type.data.size());
case Column::Time:
return time.to_string();
return time.to_deprecated_string();
default:
VERIFY_NOT_REACHED();
}

6
Userland/Applets/Network/main.cpp
View file

@ -122,13 +122,13 @@ private:
auto json = JsonValue::from_string(file_contents_or_error.value());
if (json.is_error())
return adapter_info.to_string();
return adapter_info.to_deprecated_string();
int connected_adapters = 0;
json.value().as_array().for_each([&adapter_info, &connected_adapters](auto& value) {
auto& if_object = value.as_object();
auto ip_address = if_object.get("ipv4_address"sv).as_string_or("no IP");
auto ifname = if_object.get("name"sv).to_string();
auto ifname = if_object.get("name"sv).to_deprecated_string();
auto link_up = if_object.get("link_up"sv).as_bool();
auto link_speed = if_object.get("link_speed"sv).to_i32();
@ -151,7 +151,7 @@ private:
// show connected icon so long as at least one adapter is connected
connected_adapters ? set_connected(true) : set_connected(false);
return adapter_info.to_string();
return adapter_info.to_deprecated_string();
}
DeprecatedString m_adapter_info;