RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 05:07:35 +00:00
Code Issues Activity Actions

Everywhere: Rename to_{string => deprecated_string}() where applicable

Browse source 
This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.
This commit is contained in:
Linus Groh 2022-12-06 01:12:49 +00:00 • committed by Andreas Kling
parent 6e19ab2bbc
commit 57dc179b1f
597 changed files with 1973 additions and 1972 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Applications/TextEditor/FileArgument.cpp
View file

@ -26,9 +26,9 @@ FileArgument::FileArgument(DeprecatedString file_argument)
// Match 0 group 2: column number
if (groups.size() > 2) {
// Both a line and column number were specified.
auto filename = groups.at(0).view.to_string();
auto initial_line_number = groups.at(1).view.to_string().to_int();
auto initial_column_number = groups.at(2).view.to_string().to_int();
auto filename = groups.at(0).view.to_deprecated_string();
auto initial_line_number = groups.at(1).view.to_deprecated_string().to_int();
auto initial_column_number = groups.at(2).view.to_deprecated_string().to_int();
m_filename = filename;
if (initial_line_number.has_value() && initial_line_number.value() > 0)
@ -37,15 +37,15 @@ FileArgument::FileArgument(DeprecatedString file_argument)
m_column = initial_column_number.value();
} else if (groups.size() == 2) {
// Only a line number was specified.
auto filename = groups.at(0).view.to_string();
auto initial_line_number = groups.at(1).view.to_string().to_int();
auto filename = groups.at(0).view.to_deprecated_string();
auto initial_line_number = groups.at(1).view.to_deprecated_string().to_int();
m_filename = filename;
if (initial_line_number.has_value() && initial_line_number.value() > 0)
m_line = initial_line_number.value();
} else {
// A colon was found at the end of the file name but no values were found after it.
m_filename = groups.at(0).view.to_string();
m_filename = groups.at(0).view.to_deprecated_string();
}
}
}

6
Userland/Applications/TextEditor/MainWidget.cpp
View file

@ -331,7 +331,7 @@ WebView::OutOfProcessWebView& MainWidget::ensure_web_view()
m_page_view = web_view_container.add<WebView::OutOfProcessWebView>();
m_page_view->on_link_hover = [this](auto& url) {
if (url.is_valid())
m_statusbar->set_text(url.to_string());
m_statusbar->set_text(url.to_deprecated_string());
else
update_statusbar();
};
@ -711,7 +711,7 @@ void MainWidget::update_title()
else
builder.append(m_path);
builder.append("[*] - Text Editor"sv);
window()->set_title(builder.to_string());
window()->set_title(builder.to_deprecated_string());
}
bool MainWidget::read_file(Core::File& file)
@ -855,7 +855,7 @@ void MainWidget::update_statusbar()
auto word_count = m_editor->number_of_words();
builder.appendff("{} {} ({} {})", text.length(), text.length() == 1 ? "character" : "characters", word_count, word_count != 1 ? "words" : "word");
}
m_statusbar->set_text(0, builder.to_string());
m_statusbar->set_text(0, builder.to_deprecated_string());
if (m_editor && m_editor->syntax_highlighter()) {
auto language = m_editor->syntax_highlighter()->language();